Skip to content

[Gateway] : Add FoxWallet to ecosystem#452

Closed
Nuts444 wants to merge 9 commits intobobanetwork:developfrom
Nuts444:develop
Closed

[Gateway] : Add FoxWallet to ecosystem#452
Nuts444 wants to merge 9 commits intobobanetwork:developfrom
Nuts444:develop

Conversation

@Nuts444
Copy link
Copy Markdown

@Nuts444 Nuts444 commented Nov 11, 2022

#:clipboard: Add associated issues, tickets, docs URL here.

Overview

Add Fox Wallet to Boba ecosystem.

Changes

  • Add Fox Wallet to Boba ecosystem.

Testing

Fox wallet with image will be visible on the ecosystem page on the gateway as a wallet category.

@InoMurko InoMurko requested a review from sk-enya November 14, 2022 15:13
@InoMurko
Copy link
Copy Markdown
Contributor

@sk-enya can you just fix the PR description please?

@sk-enya sk-enya requested a review from boyuan-chen November 15, 2022 07:39
@sk-enya sk-enya changed the title add FoxWallet [ Gateway ] : Add FoxWallet to ecosystem Nov 16, 2022
@sk-enya sk-enya changed the title [ Gateway ] : Add FoxWallet to ecosystem [Gateway] : Add FoxWallet to ecosystem Nov 16, 2022
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 16, 2022

Codecov Report

Base: 44.74% // Head: 44.74% // No change to project coverage 👍

Coverage data is based on head (546979a) compared to base (206cf40).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #452   +/-   ##
========================================
  Coverage    44.74%   44.74%           
========================================
  Files          106      106           
  Lines         4253     4253           
  Branches       847      847           
========================================
  Hits          1903     1903           
  Misses        2350     2350           
Flag Coverage Δ
boba-contracts 20.02% <ø> (ø)
contracts 79.30% <ø> (ø)
core-utils 86.80% <ø> (ø)
data-transport-layer 31.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@InoMurko
Copy link
Copy Markdown
Contributor

@Nuts444 can I ask you to resolve the conflicts please? thank you

@sk-enya
Copy link
Copy Markdown
Contributor

sk-enya commented Jan 18, 2023

closing as added this changes to https://github.com/bobanetwork/boba/pull/522

@sk-enya sk-enya closed this Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants