Merged
Conversation
boyuan-chen
requested review from
InoMurko,
java-spaces,
mmontour1306,
souradeep-das,
trangtran-enya and
wsdt
InoMurko
reviewed
Oct 16, 2022
InoMurko
reviewed
Oct 16, 2022
Contributor
|
should we merge the complete 'More advanced options for Special NFTs' from here so all cases of metadata is covered? |
wsdt
approved these changes
Oct 17, 2022
Contributor
wsdt
left a comment
wsdt
left a comment
There was a problem hiding this comment.
looks good to me after adding Ino's feedback
Contributor
Author
It's added. |
InoMurko
reviewed
Oct 20, 2022
Co-authored-by: Ino Murko <ino.murko.github@protonmail.com>
InoMurko
approved these changes
Oct 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📋 Add associated issues, tickets, docs URL here.
Overview
Describe what your Pull Request is about in a few sentences.
Rewrite NFT bridge docs
Changes
Describe your changes and implementation choices. More details make PRs easier to review.
Testing
Describe how to test your new feature/bug fix and if possible, a step by step guide on how to demo this.