Skip to content

Fix ReadStorageAt #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
boyuan-chen wants to merge 3 commits into from
Closed

Fix ReadStorageAt #302

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4aef8f2
Fix ReadStorageAt
boyuan-chen Feb 25, 2025
752ba6d
Ignore receipt check for bnb testnet 48576786
boyuan-chen Feb 26, 2025
b2a1080
Merge branch 'develop' into fix-bnb-testnet
boyuan-chen Feb 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions op-service/sources/eth_client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,6 +376,14 @@ func (s *EthClient) GetStorageAt(ctx context.Context, address common.Address, st
// ReadStorageAt is a convenience method to read a single storage value at the given slot in the given account.
// The storage slot value is verified against the state-root of the given block if we do not trust the RPC provider, or directly retrieved without proof if we do trust the RPC.
func (s *EthClient) ReadStorageAt(ctx context.Context, address common.Address, storageSlot common.Hash, blockHash common.Hash) (common.Hash, error) {
chainId, err := s.ChainID(ctx)
if err != nil {
return common.Hash{}, fmt.Errorf("failed to fetch chain id: %w", err)
}
// BSC Testnet doesn't support fetching the storage based on block hash
if chainId.Cmp(big.NewInt(97)) == 0 {
return s.GetStorageAt(ctx, address, storageSlot, "latest")
}
if s.trustRPC {
return s.GetStorageAt(ctx, address, storageSlot, blockHash.String())
}
Expand Down