Cleanup Now API in favor of system defined implementations
#182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nekevss
added
C-enhancement
nekevss
force-pushed
the
impl-sys-hooks
branch
from
c97405a to
db35907
Compare
nekevss
changed the title
SystemHooks trait + feature flagged DefaultSystemHooks and adjust Now as neededNow API in favor of system defined implementations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds aSystemHookstrait for providing system getters for system time and system time zone. It also adjusts the "now" feature to a "sys" feature flag forDefaultSystemHooks.This PR provides more generalized methods that can be used in combination with a system hooks.