-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More FFI APIs #178
More FFI APIs #178
Conversation
I'll take a look at it ASAP |
useful bit of context: I wrote this on the plane and rebased it later |
The quickest way to fix this issue is to opt out But as mentioned in #165. The wrapper concept around core might need to be looked at again. |
@nekevss I don't think opting in to a feature should ever break code? |
For example, I'm having code break because YearMonth uses the core duration. From what I can tell this core vs builtin split doesn't quite work: Core contains types which reference each other, and only some of them are wrapped in builtin and reexported, so you get a broken mix of things.
|
I've done the fix to make this landable, but this situation isn't ideal. |
Unfortunately the
temporal_core
stuff breaks all the duration APIs, and I don't understand what it's doing. I wrote this PR before that change, help updating it to work with Duration appreciated.In general I don't think it's a good idea to have two separate Duration types with differing APIs. Opting in to features might enable new APIs, but it's not kosher to disable APIs that way, which seems to be the case here.