Sync upstream/master
#21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Razican
reviewed
Oct 21, 2022
| - run: cargo miri test | ||
| env: | ||
| MIRIFLAGS: "-Zmiri-tag-raw-pointers" | ||
| MIRIFLAGS: -Zmiri-strict-provenance |
There was a problem hiding this comment.
I like that they are using miri here, maybe we could also use it in Boa.
There was a problem hiding this comment.
Yes, I think so too maybe it could catch some hard to find bugs
There was a problem hiding this comment.
Let's open an issue about this
Comment on lines
+11
to
+12
| env: | ||
| RUSTFLAGS: -Dwarnings |
There was a problem hiding this comment.
This could maybe be added to Boa too, to avoid having warnings in the repo.
HalidOdat
force-pushed
the
upstream-sync
branch
from
8f5c3ec
to
fd2f25e
Compare
Razican
approved these changes
Oct 21, 2022
RageKnify
approved these changes
Oct 21, 2022
HalidOdat
added a commit
that referenced
this pull request
Mar 15, 2023
Co-authored-by: Aphek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.