Add a js_class to implement the Class trait without boilerplate #3872
Conversation
This also adds a JsInstance that verifies that `this` is of the proper class, and an `Ignore` that ignore arguments. The syntax is a bit special because of limitations of macro_rules. For example, the way fields are defined. It was impossible to keep both assignments (e.g. `public field = 123;`) and dynamic fields. This reduces significantly the boilerplate for declaring classes. The example in class.rs is more than twice as long (if you remove comments) than the macro is.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3872 +/- ##
==========================================
+ Coverage 47.24% 51.19% +3.94%
==========================================
Files 476 470 -6
Lines 46892 45401 -1491
==========================================
+ Hits 22154 23242 +1088
+ Misses 24738 22159 -2579 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Really impressive work! Definitely having a boilerplate-free way to create JsClasses is a thing we should have.
I was wondering, what is the benefit of doing it with a macro_rules vs a procedural macro? I'm just worried about using macro_rules for this since it would pretty much disable all IDE autocompletions vs a procedural macro, which is a lot nicer to IDEs.
I was envisioning something like wasm_bindgen's getter and setter attributes
|
It was just easier for me to build a macro, and I wanted to have a more JS-ey way to describe the class. It would make sense to have a proc macro at some point, I just don't have the time yet. This reduces a lot of code already. |
Fail enough. I think we can start by offering a macro rules, then switch to a proc macro in the future. |
|
@jedel1043 PTAL |
This also adds a JsInstance that verifies that
thisis of the proper class, and anIgnorethat ignore arguments.The syntax is a bit special because of limitations of macro_rules. For example, the way fields are defined. It was impossible to keep both assignments (e.g.
public field = 123;) and dynamic fields.This reduces significantly the boilerplate for declaring classes. The example in class.rs is more than twice as long (if you remove comments) than the macro is.