[cpp][r] SVD on row-major matrix remainder fix #55

bnprks · Nov 15, 2023 · 6abe291 · 6abe291
1 parent 6597d79
commit 6abe291
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/R/matrix.R b/R/matrix.R
@@ -2393,6 +2393,7 @@ setMethod("svds", signature(A="IterableMatrix"), function (A, k, nu = k, nv = k,
     k, 
     solver_params[["ncv"]],
     solver_params[["maxitr"]],
-    solver_params[["tol"]]
+    solver_params[["tol"]],
+    A@transpose
   )
 })
diff --git a/src/matrix_utils.cpp b/src/matrix_utils.cpp
@@ -430,10 +430,10 @@ Eigen::MatrixXd wilcoxon_rank_sum_pval_double_cpp(SEXP matrix, std::vector<uint3
 }
 
 // [[Rcpp::export]]
-SEXP svds_cpp(SEXP matrix, int k, int n_cv, int maxit, double tol) { 
+SEXP svds_cpp(SEXP matrix, int k, int n_cv, int maxit, double tol, bool transpose) { 
     auto mat = take_unique_xptr<MatrixLoader<double>>(matrix);
     SVDResult res = run_with_R_interrupt_check(
-        svd, mat.get(), k, n_cv, maxit, tol
+        svd, mat.get(), k, n_cv, maxit, tol, transpose
     );
     if (!res.success) warning("SVD calculation did not converge");
     return List::create(