v8: fix --always-opt bug

Don't try to optimize known-unoptimizable functions when --always-opt is specified on the command line, it makes Crankshaft emit wrong code. This was fixed upstream when improved WASM support was introduced but that specific change can't be back-ported because it depends on prior work that doesn't exist in V8 5.1. Ergo, I decided to redo the fix from scratch. PR-URL: nodejs#9293 Reviewed-By: Ali Ijaz Sheikh <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Myles Borins <[email protected]>
bnoordhuis · Mar 2, 2017 · daa56a6 · daa56a6
1 parent 1d631ce
commit daa56a6
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/deps/v8/src/compiler.cc b/deps/v8/src/compiler.cc
@@ -1926,7 +1926,10 @@ void Compiler::PostInstantiation(Handle<JSFunction> function,
                                  PretenureFlag pretenure) {
   Handle<SharedFunctionInfo> shared(function->shared());
 
-  if (FLAG_always_opt && shared->allows_lazy_compilation()) {
+  if (FLAG_always_opt &&
+      shared->allows_lazy_compilation() &&
+      !shared->optimization_disabled() &&
+      !shared->dont_crankshaft()) {
     function->MarkForOptimization();
   }