Fix workspace manifest loading #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
taking a leap of faith as it really works locally :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two things:
[workspace]property: we need to look at the workspace manifest, to the child one.cargo_toml, that makes it impossible to properly usefrom_path_with_metadata(unless I'm mistaken! see full analysis), so we need to use other methods to get the content, with a slightly different order. That's fine, it's quite internal and shouldn't change much over time.@Veetaha Would you be so kind as to try this branch, please, to confirm whether this fixes the issue you were running into? At least for me, it does fix it where I saw it (internal repositories).