Skip to content

Commit

Permalink
version: take --short into account when updating
Browse files Browse the repository at this point in the history
Fixes python-poetry#3577.

This makes `poetry version --short <version>` output only the updated
version number, similarly to `poetry version --short`.
  • Loading branch information
sprt authored and kasteph committed Jan 16, 2021
1 parent de0b32c commit a106cb2
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 4 deletions.
11 changes: 7 additions & 4 deletions poetry/console/commands/version.py
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,14 @@ def handle(self):
self.poetry.package.pretty_version, version
)

self.line(
"Bumping version from <b>{}</> to <fg=green>{}</>".format(
self.poetry.package.pretty_version, version
if self.option("short"):
self.line("{}".format(version))
else:
self.line(
"Bumping version from <b>{}</> to <fg=green>{}</>".format(
self.poetry.package.pretty_version, version
)
)
)

content = self.poetry.file.read()
poetry_content = content["tool"]["poetry"]
Expand Down
10 changes: 10 additions & 0 deletions tests/console/commands/test_version.py
Original file line number Diff line number Diff line change
Expand Up @@ -51,3 +51,13 @@ def test_version_show(tester):
def test_short_version_show(tester):
tester.execute("--short")
assert "1.2.3\n" == tester.io.fetch_output()


def test_version_update(tester):
tester.execute("2.0.0")
assert "Bumping version from 1.2.3 to 2.0.0\n" == tester.io.fetch_output()


def test_short_version_update(tester):
tester.execute("--short 2.0.0")
assert "2.0.0\n" == tester.io.fetch_output()

0 comments on commit a106cb2

Please sign in to comment.