Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Adds Norwegian translation. #160

Merged
merged 6 commits into from
Aug 3, 2021
Merged

✨ Adds Norwegian translation. #160

merged 6 commits into from
Aug 3, 2021

Conversation

tplive
Copy link
Contributor

@tplive tplive commented Aug 2, 2021

I've punched up the Norwegian translation as I want my family and friends to print their own cards.. ;)

@Starefossen
Copy link

Awesome 😍

Copy link
Owner

@bndw bndw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tplive thanks for the translation! Would you mind running make fmt.write to format the changes (looks like the pre-commit hook didn't run 🤔 ) and I'd be happy to merge

@tplive
Copy link
Contributor Author

tplive commented Aug 3, 2021

Sorry, I kinda jumped the gun on the first PR. Back at work from a long vacation an eager to make a contribution. :) Fixed the formatting, but then I see that Korean has also been added to master. Resolved that merge in a separate branch, think it should be ok.

Copy link
Owner

@bndw bndw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small ordering change and we're good! Thanks again ❤️

@tplive
Copy link
Contributor Author

tplive commented Aug 3, 2021

...and if all those merges add up to that simple change, we're all set! 😅

Copy link
Owner

@bndw bndw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@bndw bndw merged commit 0aa3269 into bndw:master Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants