Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve description of -nouses #6441

Merged
merged 1 commit into from
Jan 23, 2025
Merged

improve description of -nouses #6441

merged 1 commit into from
Jan 23, 2025

Conversation

chrisrueger
Copy link
Contributor

Closes #6439

@chrisrueger
improve description of -nouses
b9ac0a5 
Signed-off-by: Christoph Rueger <[email protected]>
@chrisrueger chrisrueger linked an issue Jan 23, 2025 that may be closed by this pull request
Better explain the implications of -nouses instruction #6439
Closed
@chrisrueger
Copy link
Contributor Author

chrisrueger commented Jan 23, 2025 •
edited
Loading

@laeubi Feel free to propose changes, you are more expert and versed in this topic. I used the sentence from your issue here apache/commons-parent#581

Since this is docu we can push it almost instantly and are not bound to a bndtools release.

laeubi
laeubi approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@laeubi laeubi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable to me, I would probably add a reference to the spec.

@chrisrueger
Copy link
Contributor Author

I would probably add a reference to the spec.

what do you mean? i added a link to https://docs.osgi.org/specification/osgi.core/8.0.0/framework.module.html#i3127019

@laeubi
Copy link
Contributor

laeubi commented Jan 23, 2025

I would probably add a reference to the spec.

what do you mean? i added a link to https://docs.osgi.org/specification/osgi.core/8.0.0/framework.module.html#i3127019

uups... I missed that :-D looks all fine to me.

@chrisrueger chrisrueger merged commit dbc63d2 into master Jan 23, 2025
3 checks passed
@chrisrueger chrisrueger deleted the 6439-better-explain-the-implications-of--nouses-instruction branch January 23, 2025 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laeubi laeubi laeubi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Better explain the implications of -nouses instruction
2 participants
@chrisrueger @laeubi