Extract code to automatically derive data from maven-project #6362
Conversation
laeubi
force-pushed
the
extract_common_code_to_maven_artifact
branch
2 times, most recently
from
f330ad1
to
f3cc8d4
Compare
|
The build failure looks like my change in the shared lib is not picked up by the maven build. |
|
@bjhargrave any hint / idea what could be wrong? |
I don't know. But this PR seems to be poorly designed from an object oriented perspective. There are 2 things unrelated: reading the configuration from the pom/bnd file and setting some defaults, for bundle building, if they have not been set. I don't see why BndConfiguration should have an instance method for setting defaults since default settings never needed the configuration. That seems a poor place to put default settings for the bnd maven plugin and conflates two things. |
laeubi
force-pushed
the
extract_common_code_to_maven_artifact
branch
from
f3cc8d4
to
aa3c4e2
Compare
I think my naming was not really good here, I have now adjusted it to better reflect the meaning. It is actually not any defaults but apply some implicit configuration (and just converted to bnd instructions). Still of course it could also be extracted in a separate class, the main point is that it should not be mangled with the Mojo so it can be used in other context as well. Sadly this would not resolve the issue that for some reason the invoker tests seem not to "see" the bnd-build jar file with the shared code but some outdated variant :-\ |
|
The problem seems to be that the bnd-baseline-maven-plugin has no dependency to biz.aQute.bnd.maven in its pom.xml. Therefore, the latest biz.aQute.bnd.maven it is not copied to the testing repo. With the wonderful maven logic, it will then likely get it from some random repository, which happens to be the previous version ... Other bnd plugins might have the same problem although the bnd-maven-plugin seems ok. However, I'd like to see @bjhargrave 's concerns addressed. |
Currently if one loads the configuration with aQute.bnd.maven.lib.configuration.BndConfiguration then only the configuration itself is loaded, but actually some implicit configuration later apply (e.g. from the maven project configuration) that is currently only performed by the AbstractBndMavenPlugin. This extracts this logic from the AbstractBndMavenPlugin into the BndConfiguration class for the following benefits: - making the AbstractBndMavenPlugin maintain less code in the execute method - allow other users of BndConfiguration to easily inherit common defaults - separation of concerns, easier to debug and understand Signed-off-by: Christoph Läubrich <[email protected]>
laeubi
force-pushed
the
extract_common_code_to_maven_artifact
branch
from
aa3c4e2
to
11e675e
Compare
| @@ -47,6 +57,160 @@ public File loadProperties(Processor processor) throws Exception { | |||
| return loadProjectProperties(processor, project, project, configuration); | |||
| } | |||
|
|
|||
| public void loadImplicitProperties(Processor processor, String outputTimestamp) throws Exception { | |||
There was a problem hiding this comment.
Perhaps a better method name like setPropertiesDefaults. The method is not loading anything. It is setting default values for some bnd properties based upon the values of bnd properties and maven project properties.
It is unfortunate that you pass outputTimestamp here. It would be nicer if this value could be found through the plugin configuration since we may need to pass more such values in the future and end up with having to overload this method.
| <dependency> | ||
| <groupId>${project.groupId}</groupId> | ||
| <artifactId>biz.aQute.bnd.maven</artifactId> | ||
| </dependency> |
There was a problem hiding this comment.
Looks like this same change is needed for bnd-reporter-maven-plugin.
Currently if one loads the configuration with
aQute.bnd.maven.lib.configuration.BndConfigurationthen only theconfiguration itself is loaded, but actually some implicit configuration later apply (e.g. from the maven project configuration)
that is currently only performed by the
AbstractBndMavenPlugin.This extracts this logic from the
AbstractBndMavenPlugininto theBndConfigurationclass for the following benefits:AbstractBndMavenPluginmaintain less code in the executemethod
BndConfigurationto easily inherit commondefaults