feat: implement the Bohr upgrade of BSC #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -8,6 +8,8 @@ use std::collections::{BTreeMap, HashMap}; | |||
|
|
|||
| /// Number of blocks after which to save the snapshot to the database | |||
| pub const CHECKPOINT_INTERVAL: u64 = 1024; | |||
| /// Default turn length before Bohr upgrade | |||
| pub const DEFAULT_TURN_LENGTH: u8 = 1; | |||
There was a problem hiding this comment.
There're 2 DEFAULT_TURN_LENGTH definition
There was a problem hiding this comment.
They are not the same, one is the size of the variable, one is the default value of turn_length
unclezoro
reviewed
Jul 31, 2024
unclezoro
reviewed
Jul 31, 2024
NathanBSC
reviewed
Aug 2, 2024
crates/bsc/consensus/src/abi.rs
Outdated
| @@ -4494,6 +4507,19 @@ lazy_static! { | |||
| ], | |||
| "stateMutability": "view" | |||
| }, | |||
| { | |||
NathanBSC
approved these changes
Aug 2, 2024
buddh0
approved these changes
Aug 2, 2024
unclezoro
approved these changes
Aug 5, 2024
This was referenced Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr will implement the below beps of BSC and introduce the
Bohrupgrade:bnb-chain/BEPs#341
bnb-chain/BEPs#402
bnb-chain/BEPs#404
You can refer to the PRs of BSC:
bnb-chain/bsc#2482
bnb-chain/bsc#2502
bnb-chain/bsc#2558
Rationale
Implement the BEPs of BSC
Example
n/a
Changes
Notable changes:
Potential Impacts
n/a