feat: 450ms hard fork by constwz · Pull Request #96 · bnb-chain/reth-bsc

constwz · 2025-10-15T10:03:25Z

Description

feat: 450ms hard fork

geth-bsc prs:
https://github.com/bnb-chain/bsc/pull/3367/files
https://github.com/bnb-chain/bsc/pull/3368/files
bnb-chain/bsc#3397
bnb-chain/bsc#3400

BEP:
https://github.com/bnb-chain/BEPs/blob/master/BEPs/BEP-619.md
https://github.com/bnb-chain/BEPs/blob/master/BEPs/BEP-590.md

will-2012 · 2025-10-15T10:22:40Z

Pls link the related geth-bsc PRs and BEPs.

Copilot

Pull Request Overview

This PR implements the Fermi hard fork for the BSC (Binance Smart Chain), scheduled for October 30, 2025. The hard fork includes updates to system contracts, adjustments to attestation validation logic to allow target blocks within 3 ancestor generations, and corresponding configuration changes.

Key changes:

Addition of Fermi hard fork definition and activation timestamps across mainnet, testnet, and Rialto networks
Implementation of 3-generation ancestor depth for attestation target block validation
Updates to system contracts for Fermi hard fork (StakeHub contracts for both mainnet and Rialto)

Reviewed Changes

Copilot reviewed 10 out of 11 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
src/hardforks/bsc.rs	Adds Fermi hardfork enum variant, activation timestamps, and SpecId mapping
src/hardforks/mod.rs	Adds convenience method to check Fermi activation
src/node/evm/config.rs	Updates REVM spec selection to include Fermi check
src/node/evm/pre_execution.rs	Implements K_ANCESTOR_GENERATION_DEPTH constant and 3-generation ancestor validation logic
src/consensus/parlia/snapshot.rs	Modifies attestation update logic to conditionally apply validation based on Fermi activation
src/chainspec/bsc.rs	Updates fork ID test expectation for next fork timestamp
src/system_contracts/mod.rs	Adds Fermi to system contract hardfork list and directory mapping
src/system_contracts/fermi/rialto/StakeHubContract	Adds compiled StakeHub contract bytecode for Rialto
src/system_contracts/fermi/mainnet/StakeHubContract	Adds compiled StakeHub contract bytecode for mainnet

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-10-15T11:11:50Z

src/hardforks/mod.rs

        self.bsc_fork_activation(BscHardfork::Maxwell).active_at_timestamp(timestamp)
    }
+
+    /// Convenience method to check if [`BscHardfork::Maxwell`] is active at a given timestamp.


The documentation comment incorrectly references Maxwell instead of Fermi. Update the comment to: /// Convenience method to check if [BscHardfork::Fermi] is active at a given timestamp.

Suggested change

/// Convenience method to check if [`BscHardfork::Maxwell`] is active at a given timestamp.

/// Convenience method to check if [`BscHardfork::Fermi`] is active at a given timestamp.

Copilot · 2025-10-15T11:11:50Z

src/node/evm/pre_execution.rs

    }

+    fn get_ancestor_generation_depth(&self, header: &Header) -> u64 {
+        if self.spec.is_fermi_active_at_timestamp(header.number(),header.timestamp) {


Missing space after comma in function call. Add a space after the comma for consistency: is_fermi_active_at_timestamp(header.number(), header.timestamp)

Suggested change

if self.spec.is_fermi_active_at_timestamp(header.number(),header.timestamp) {

if self.spec.is_fermi_active_at_timestamp(header.number(), header.timestamp) {

Copilot · 2025-10-15T11:11:50Z

src/consensus/parlia/snapshot.rs

            }
        }
-        snap.update_attestation(next_header, attestation);
+        snap.update_attestation(chain_spec,next_header, attestation);


Missing space after comma in function call. Add a space after the comma for consistency: update_attestation(chain_spec, next_header, attestation)

Suggested change

snap.update_attestation(chain_spec,next_header, attestation);

snap.update_attestation(chain_spec, next_header, attestation);

Copilot · 2025-10-15T11:11:51Z

src/node/evm/pre_execution.rs

+                }
+                .into());
+            }



Trailing whitespace should be removed from this line.

Suggested change

Copilot · 2025-10-15T11:11:51Z

src/hardforks/bsc.rs

            (Self::Pascal.boxed(), ForkCondition::Timestamp(1754967081)),
            (Self::Lorentz.boxed(), ForkCondition::Timestamp(1754967081)),
            (Self::Maxwell.boxed(), ForkCondition::Timestamp(1754967101)),
+            (Self::Fermi.boxed(), ForkCondition::Timestamp(1761753600)), 


Trailing whitespace after the comma should be removed.

Suggested change

(Self::Fermi.boxed(), ForkCondition::Timestamp(1761753600)),

(Self::Fermi.boxed(), ForkCondition::Timestamp(1761753600)),

galaio · 2025-10-15T13:19:43Z

Does there miss FERMI_BLOCK_INTERVAL change?

will-2012 · 2025-10-15T14:51:52Z

Does there miss FERMI_BLOCK_INTERVAL change?

+1

Pls pay more attention to the following related adaptation:

reth-bsc/src/consensus/parlia/snapshot.rs

Lines 30 to 32 in d0f643b

    
           pub const DEFAULT_BLOCK_INTERVAL: u64 = 3000;   // 3000 ms 
        
           pub const LORENTZ_BLOCK_INTERVAL: u64 = 1500;   // 1500 ms 
        
           pub const MAXWELL_BLOCK_INTERVAL: u64 = 750;   //  750 ms

constwz · 2025-10-16T01:01:54Z

Pls link the related geth-bsc PRs and BEPs.

done

constwz · 2025-10-16T01:02:12Z

Does there miss FERMI_BLOCK_INTERVAL change?

+1

Pls pay more attention to the following related adaptation:

reth-bsc/src/consensus/parlia/snapshot.rs

Lines 30 to 32 in d0f643b

pub const DEFAULT_BLOCK_INTERVAL: u64 = 3000; // 3000 ms

pub const LORENTZ_BLOCK_INTERVAL: u64 = 1500; // 1500 ms

pub const MAXWELL_BLOCK_INTERVAL: u64 = 750; // 750 ms

fixed

will-2012 · 2025-10-16T01:19:35Z

LGTM, I think once it is confirmed to pass the FERMI QA test, it can be merged. c.c. @graceharuki

feat: 450ms hard fork

b62fdbb

constwz requested review from graceharuki and joey0612 as code owners October 15, 2025 10:03

fix: updateAttestation

ef9a11c

constwz force-pushed the feat-450ms-hf branch from 3d38b31 to ef9a11c Compare October 15, 2025 10:13

will-2012 added the R4R label Oct 15, 2025

MatusKysel requested a review from Copilot October 15, 2025 11:11

Copilot AI reviewed Oct 15, 2025

View reviewed changes

MatusKysel approved these changes Oct 15, 2025

View reviewed changes

fix: snap block interval

c31cb90

fix: modify hf time

c11b87d

constwz force-pushed the feat-450ms-hf branch from 101d534 to f96b35c Compare October 21, 2025 10:00

fix: verify vote attestation

474eed7

constwz force-pushed the feat-450ms-hf branch from f96b35c to 474eed7 Compare October 21, 2025 11:58

perf: ancestor log

bb313bc

actioncli approved these changes Oct 23, 2025

View reviewed changes

joey0612 approved these changes Oct 23, 2025

View reviewed changes

constwz merged commit 7d29150 into develop Oct 23, 2025
8 checks passed

zlacfzy pushed a commit that referenced this pull request Nov 5, 2025

feat: 450ms hard fork (#96)

9c22da9

sysvm deleted the feat-450ms-hf branch November 6, 2025 03:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: 450ms hard fork#96

feat: 450ms hard fork#96
constwz merged 6 commits intodevelopfrom
feat-450ms-hf

constwz commented Oct 15, 2025 •

edited

Loading

Uh oh!

will-2012 commented Oct 15, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Oct 15, 2025

Uh oh!

Copilot AI Oct 15, 2025

Uh oh!

Copilot AI Oct 15, 2025

Uh oh!

Copilot AI Oct 15, 2025

Uh oh!

Copilot AI Oct 15, 2025

Uh oh!

galaio commented Oct 15, 2025

Uh oh!

will-2012 commented Oct 15, 2025 •

edited

Loading

Uh oh!

constwz commented Oct 16, 2025

Uh oh!

constwz commented Oct 16, 2025

Uh oh!

will-2012 commented Oct 16, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

	/// Convenience method to check if [`BscHardfork::Maxwell`] is active at a given timestamp.
	/// Convenience method to check if [`BscHardfork::Fermi`] is active at a given timestamp.

	if self.spec.is_fermi_active_at_timestamp(header.number(),header.timestamp) {
	if self.spec.is_fermi_active_at_timestamp(header.number(), header.timestamp) {

	snap.update_attestation(chain_spec,next_header, attestation);
	snap.update_attestation(chain_spec, next_header, attestation);

	(Self::Fermi.boxed(), ForkCondition::Timestamp(1761753600)),
	(Self::Fermi.boxed(), ForkCondition::Timestamp(1761753600)),

Conversation

constwz commented Oct 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

will-2012 commented Oct 15, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

galaio commented Oct 15, 2025

Uh oh!

will-2012 commented Oct 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

constwz commented Oct 16, 2025

Uh oh!

constwz commented Oct 16, 2025

Uh oh!

will-2012 commented Oct 16, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

constwz commented Oct 15, 2025 •

edited

Loading

will-2012 commented Oct 15, 2025 •

edited

Loading