fix: remove misuse merge_transitions#165
Merged
Conversation
constwz
approved these changes
Nov 14, 2025
0xbundler
approved these changes
Nov 14, 2025
galaio
approved these changes
Nov 14, 2025
joey0612
approved these changes
Nov 14, 2025
This was referenced Nov 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove misuse merge_transitions.
Rationale
merge_transitionsshould not be called inside the executor; it should be called by the executor caller.More importantly, multiple calls to this function have side effects, potentially corrupting data, leading to mismatch roots, execution phase errors, database integrity errors, and so on.
Example
related issues:
#162
#163
Changes
Notable changes:
Potential Impacts
N/A.