Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bc fusion hardfork implementation #983

Merged
merged 17 commits into from
Nov 30, 2023
Merged

Conversation

j75689
Copy link
Contributor

@j75689 j75689 commented Aug 28, 2023

Description

This PR has implemented the function for the bc-fusion hard forks and token recovery signing tool.

Rationale

For BC-Fusion plan:
bnb-chain/bnc-cosmos-sdk#358

Token Migration after BC-Fusion
bnb-chain/BEPs#299

Example

Sign Token Recover Request Msg

./build/tbnbcli recover sign-token-recover-request --amount 1000000000 --token-symbol BNB --recipient 0x5b38da6a701c568545dcfcb03fcb875f56beddc4  --from sig_test --chain-id Binance-Chain-Ganges

Changes

Notable changes:

  • timelock
  • swap
  • freeze
  • token recover

Preflight checks

  • build passed (make build)
  • tests passed (make test)
  • integration tests passed (make integration_test)
  • manual transaction test passed (cli invoke)

plugins/tokens/plugin.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Aug 28, 2023

Codecov Report

Attention: 74 lines in your changes are missing coverage. Please review.

Comparison is base (dac83b6) 49.08% compared to head (4a4651d) 48.81%.

Files Patch % Lines
plugins/tokens/plugin.go 0.00% 39 Missing ⚠️
plugins/tokens/swap/handler.go 42.85% 6 Missing and 2 partials ⚠️
plugins/tokens/timelock/handler.go 0.00% 6 Missing ⚠️
plugins/tokens/timelock/keys.go 57.14% 4 Missing and 2 partials ⚠️
plugins/tokens/swap/keeper.go 0.00% 5 Missing ⚠️
plugins/tokens/freeze/handler.go 0.00% 2 Missing and 1 partial ⚠️
plugins/tokens/issue/handler.go 0.00% 2 Missing and 1 partial ⚠️
plugins/tokens/timelock/keeper.go 0.00% 3 Missing ⚠️
plugins/dex/order/handler.go 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@              Coverage Diff              @@
##           bc-fusion     #983      +/-   ##
=============================================
- Coverage      49.08%   48.81%   -0.28%     
=============================================
  Files            127      127              
  Lines          12703    12788      +85     
=============================================
+ Hits            6235     6242       +7     
- Misses          6044     6116      +72     
- Partials         424      430       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@j75689 j75689 changed the title feat: disable msgs feat: bc fusion hardfork Nov 16, 2023
plugins/tokens/plugin.go Outdated Show resolved Hide resolved
plugins/tokens/plugin.go Outdated Show resolved Hide resolved
plugins/tokens/plugin.go Outdated Show resolved Hide resolved
@j75689 j75689 changed the base branch from develop to bc-fusion November 29, 2023 07:56
@j75689 j75689 changed the title feat: bc fusion hardfork feat: bc fusion hardfork implementation Nov 29, 2023
@j75689 j75689 marked this pull request as ready for review November 29, 2023 08:37
@unclezoro unclezoro merged commit f27a818 into bnb-chain:bc-fusion Nov 30, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants