WIP: upgrade cosmos to 0.24.2 and tm to 0.24.0 #134
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add back runMsg in checkTx - add back ctx.IsCheckTx - separate CLIContext and TxContext - copied sdk.Context, AccountMapper, bank.Keeper and other related files.
rickyyangz
requested review from
notatestuser,
ackratos,
darren-liu,
yutianwu and
Sokkary
|
would be overriden by PR#215 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pending on cosmos' upgrade to tm 0.24.0
Since tm 0.24.0 has some important features/bugfixes, we have to use this latest version. However, the latest cosmos is still using the tm 0.23.2-rc0. There are some breaking changes between the two versions.
We can track this issue. cosmos/cosmos-sdk#2219
Description
#118
Rationale
We need some features and bugfixes that cosmos and tendermint did.
Here are some main changes need to be highlighted:
Tendermint
Timestamp in block must be monotonic and equal the median of timestamps in block's LastCommit
Besides these, some other changes also have big influence.
Cosmos
Removed all tx related fields and logic (building & signing) to separate structure TxContext in x/auth/client/context
Example
Changes
Notable changes:
Preflight checks
I fixed some cosmos code on my local machine to make it run on tm 0.24.0, so the following check list is based on my fixes.
make build)make test)Will test it again after cosmos' upgrade.
Already reviewed by
...