Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove sed usage for bsc cluster #14

Merged
merged 2 commits into from
Sep 15, 2023
Merged

remove sed usage for bsc cluster #14

merged 2 commits into from
Sep 15, 2023

Conversation

Mister-EA
Copy link
Contributor

@Mister-EA Mister-EA commented Aug 24, 2023

In this PR the script for deploying a local BSC cluster is refactored, so thatsed is not longer used to modify the genesis contract templates, or the generated config.toml files from the initNetwork command .

Because of the changes from the following 2 PRs the correct contracts and config.toml can directly be generated without modifying any files from the scripts in this repo.

Now all the user has to do is edit the following files to configure the deployment:

  • genesis/genesis-template.json
  • config.toml
  • .env

Since the changes in BSC and bsc-genesis-contract have not been merged yet, you need to use the following branches to test the deployment flow:

  • toml-settings branch for BSC
  • support-local-deployment for bsc-genesis-contract

@Mister-EA Mister-EA requested a review from buddh0 August 24, 2023 16:43
@Mister-EA Mister-EA marked this pull request as draft August 24, 2023 16:44
@Mister-EA Mister-EA requested a review from j75689 August 25, 2023 13:01
@Mister-EA Mister-EA marked this pull request as ready for review August 25, 2023 13:01
buddh0
buddh0 previously approved these changes Sep 1, 2023
MatusKysel
MatusKysel previously approved these changes Sep 11, 2023
@Mister-EA Mister-EA dismissed stale reviews from MatusKysel and buddh0 via 2a99d02 September 12, 2023 14:08
@Mister-EA Mister-EA merged commit a36106a into main Sep 15, 2023
@buddh0 buddh0 deleted the refactor-scripts branch March 28, 2024 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants