Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R4R]fix:Shift panic for zero length of heads #870

Merged
merged 4 commits into from
Apr 25, 2022
Merged

[R4R]fix:Shift panic for zero length of heads #870

merged 4 commits into from
Apr 25, 2022

Conversation

qinglin89
Copy link
Contributor

@qinglin89 qinglin89 commented Apr 24, 2022 •
edited
Loading

Description

panic when length of heads equal to zero when shift

Rationale

  • TransactionsByPriceAndNonce.Shift should only be called after TransactionsByPriceAndNonce.Peek directly and void invoke on TransactionsByPriceAndNonce.Shift when Peek show a nil result, otherwise might cause a panic for zero length TransactionsByPriceAndNonce.heads when doing Shift
  • func (p *statePrefetcher) PrefetchMining(...) invoked TransactionsByPriceAndNonce.Forward before TransactionsByPriceAndNonce.Shift with no TransactionsByPriceAndNoncePeek check while TransactionsByPriceAndNonce.Forward might change TransactionsByPriceAndNonce.heads to zero length.

Example

N/A

Changes

Notable changes:

  • rearrange calling sequence in the dispatcher of prefechmining, make sure Peek be checked before Shift
    • func (p *statePrefetcher) PrefetchMining(...)

@unclezoro unclezoro changed the base branch from master to develop April 24, 2022 09:41
@unclezoro unclezoro changed the base branch from develop to master April 24, 2022 09:49
unclezoro
unclezoro requested changes Apr 24, 2022
View reviewed changes
Copy link
Collaborator

@unclezoro unclezoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do review again.

@unclezoro unclezoro merged commit 0f5a4c8 into bnb-chain:master Apr 25, 2022
This was referenced May 2, 2022
Merged
Merged
j75689 added a commit that referenced this pull request Jun 1, 2022
@j75689
Merge pull request bnb-chain#7926 from binance-chain/develop
34ce25a 
[R4R] Separate Processing and State Verification on BSC
commit 73e6147
Merge: 84bb85c 2f2b98a
Author: cryyl <[email protected]>
Date:   Fri May 6 16:48:35 2022 +0800

    Merge remote-tracking branch 'bnb-chain/develop' into separate-node

commit 84bb85c
Author: zjubfd <[email protected]>
Date:   Fri May 6 16:42:40 2022 +0800

    refine the description

commit cc1940c
Author: zjubfd <[email protected]>
Date:   Fri May 6 16:38:59 2022 +0800

    change the flag description

commit e440880
Author: dean65 <[email protected]>
Date:   Fri May 6 02:17:24 2022 +0800

    fix TestFastNode

commit 4001f37
Author: dean65 <[email protected]>
Date:   Fri May 6 02:16:57 2022 +0800

    fix sorting difflayer.storage

commit e93cced
Author: dean65 <[email protected]>
Date:   Fri May 6 01:06:14 2022 +0800

    use NewTimer instead of time.After

commit f027818
Author: cryyl <[email protected]>
Date:   Thu May 5 19:10:52 2022 +0800

    fix to resolve comments

    Signed-off-by: cryyl <[email protected]>

commit ae3bdea
Author: cryyl <[email protected]>
Date:   Thu May 5 19:10:52 2022 +0800

    fix to resolve comments

    Signed-off-by: cryyl <[email protected]>

commit 2f2b98a
Merge: 0f5a4c8 55ef216
Author: zjubfd <[email protected]>
Date:   Thu May 5 17:26:16 2022 +0800

    Merge pull request #888 from bnb-chain/develop

    [R4R] Release For BSC v1.1.10

commit 2dbc8c5
Merge: e9be0d4 0132f13
Author: realuncle <[email protected]>
Date:   Wed May 4 21:37:55 2022 +0800

    Merge pull request #14 from node-real/separate-node-test

    close verifyTask when there is no valid peer and add UT tests

commit 0132f13
Author: kyrie-yl <[email protected]>
Date:   Fri Apr 29 14:39:46 2022 +0800

    add UT tests

commit e9be0d4
Author: dean65 <[email protected]>
Date:   Fri Apr 29 10:01:16 2022 +0800

    close verifyTask when length of verifyPeers is 0

commit 8929510
Author: dean65 <[email protected]>
Date:   Thu Apr 28 17:01:05 2022 +0800

    fix tests

commit 7490499
Author: dean65 <[email protected]>
Date:   Thu Apr 28 15:22:06 2022 +0800

    setup default validator for blockchain

commit ef3ec13
Author: dean65 <[email protected]>
Date:   Thu Apr 28 14:49:38 2022 +0800

    fix lint error

commit 4771d86
Merge: 5f22105 15bc254
Author: dean65 <[email protected]>
Date:   Thu Apr 28 14:36:59 2022 +0800

    Merge remote-tracking branch 'origin/develop' into separate-node

commit 5f22105
Author: j75689 <[email protected]>
Date:   Wed Apr 27 16:20:47 2022 +0800

    add unit-test for fastnode

commit 5a254c4
Author: j75689 <[email protected]>
Date:   Wed Apr 27 10:20:27 2022 +0800

    add interval when getting ErrSnapshotStale

commit b56c19c
Author: j75689 <[email protected]>
Date:   Tue Apr 26 11:18:03 2022 +0800

    fix diffhash issue

commit 0f5a4c8
Author: Leon <[email protected]>
Date:   Mon Apr 25 10:47:02 2022 +0800

    [R4R]fix:Shift panic for zero length of heads (#870)

    * fix:Shift panic for zero length of heads

    * fix: make sure peek before shift

    * refactor and update ut

    * refactor

commit dfff219
Author: j75689 <[email protected]>
Date:   Mon Apr 25 10:25:23 2022 +0800

    fix close of closed channel issue

commit 3150755
Author: j75689 <[email protected]>
Date:   Sat Apr 23 16:29:41 2022 +0800

    fix log format

commit c840e7f
Author: j75689 <[email protected]>
Date:   Sat Apr 23 06:02:29 2022 +0800

    fix diffhash mismatch issue

commit 734d17f
Author: j75689 <[email protected]>
Date:   Sat Apr 23 06:01:23 2022 +0800

    fix gracefull shutdown issue

commit a73aad6
Author: j75689 <[email protected]>
Date:   Wed Apr 20 18:00:32 2022 +0800

    fix validateBody

commit 23913cf
Author: j75689 <[email protected]>
Date:   Wed Apr 20 17:53:52 2022 +0800

    remove unused code

commit 2e6c33b
Author: j75689 <[email protected]>
Date:   Wed Apr 20 15:52:24 2022 +0800

    don't need to send verify task when node start

commit e0cf707
Author: j75689 <[email protected]>
Date:   Wed Apr 20 15:48:47 2022 +0800

    remove unused code

commit c57fdd7
Author: j75689 <[email protected]>
Date:   Wed Apr 20 15:27:30 2022 +0800

    fix comments

commit 7ad4d02
Author: j75689 <[email protected]>
Date:   Wed Apr 20 15:13:51 2022 +0800

    Revert "change type of diffLayerChanCache to sync.Map"

    This reverts commit f8c6a4a.

commit 1e44aa6
Author: j75689 <[email protected]>
Date:   Tue Apr 19 17:54:37 2022 +0800

    fixup! rewind to last non verified block when restart fast node

commit 8c6d5a8
Author: j75689 <[email protected]>
Date:   Tue Apr 19 17:37:04 2022 +0800

    fixup! rewind to last non verified block when restart fast node

commit be53153
Author: j75689 <[email protected]>
Date:   Tue Apr 19 14:39:12 2022 +0800

    rewind to last non verified block when restart fast node

commit b3a701d
Author: j75689 <[email protected]>
Date:   Tue Apr 19 13:40:17 2022 +0800

    refactor block remote validation code

commit f8c6a4a
Author: j75689 <[email protected]>
Date:   Tue Apr 19 12:46:01 2022 +0800

    change type of diffLayerChanCache to sync.Map

commit 5675916
Author: j75689 <[email protected]>
Date:   Thu Apr 14 01:16:00 2022 +0800

    fixup! put difflayer into verifyManage cache when node restart

commit 34e8ce0
Author: j75689 <[email protected]>
Date:   Thu Apr 14 00:19:41 2022 +0800

    remove testing code

commit 161c467
Merge: b978ed3 1aeadc1
Author: j75689 <[email protected]>
Date:   Thu Apr 14 00:18:02 2022 +0800

    Merge branch 'develop' into fast-node-fix

commit b978ed3
Author: j75689 <[email protected]>
Date:   Wed Apr 13 18:40:49 2022 +0800

    put difflayer into verifyManage cache when node restart

commit 1aaab76
Author: kyrie-yl <[email protected]>
Date:   Thu Apr 7 00:21:26 2022 +0800

    verify task get difflayer cache synchronously

    Signed-off-by: kyrie-yl <[email protected]>

commit 74ecbf2
Merge: 859186f 1aeadc1
Author: zjubfd <[email protected]>
Date:   Fri Apr 8 19:06:42 2022 +0800

    Merge pull request #850 from bnb-chain/develop

    [R4R] Release v1.1.9

commit 7b070c0
Author: kyrie-yl <[email protected]>
Date:   Wed Mar 2 10:07:14 2022 +0800

    resolve comments

    Signed-off-by: kyrie-yl <[email protected]>

commit 2ed75ab
Author: kyrie-yl <[email protected]>
Date:   Tue Mar 1 13:58:20 2022 +0800

    add metrics

    Signed-off-by: kyrie-yl <[email protected]>

commit f7ef016
Author: kyrie-yl <[email protected]>
Date:   Thu Feb 24 17:13:40 2022 +0800

    fast node verification and fix conflicts

    Signed-off-by: kyrie-yl <[email protected]>

commit 1e46537
Merge: 6fffa8e 0ca4bc1
Author: zjubfd <[email protected]>
Date:   Mon Feb 14 16:59:55 2022 +0800

    Merge pull request #763 from KeefeL/dev

    [R4R]Separate Processing and State Verification on BSC: sync develop branch

commit 0ca4bc1
Merge: 6fffa8e fed2f35
Author: Keefe-Liu <[email protected]>
Date:   Mon Feb 14 12:33:53 2022 +0800

    Merge branch 'develop' into separate-node

commit fed2f35
Author: KeefeL <[email protected]>
Date:   Thu Jan 27 16:50:59 2022 +0800

    testcases for trust protocol (#742)

commit 529e66e
Author: Keefe-Liu <[email protected]>
Date:   Tue Jan 25 21:18:56 2022 +0800

    fix misc bugs of verify node

commit 0405b68
Author: Keefe-Liu <[email protected]>
Date:   Fri Jan 21 18:17:06 2022 +0800

    generate diff layer by replaying block

commit 4905aab
Author: Keefe-Liu <[email protected]>
Date:   Thu Jan 20 15:22:06 2022 +0800

    testcases for getting root by diff hash

commit c6e8652
Author: Keefe-Liu <[email protected]>
Date:   Tue Jan 11 16:17:03 2022 +0800

    implement trust protocol and verify node

commit 359906c
Author: RealUncle <[email protected]>
Date:   Thu Dec 2 17:40:47 2021 +0800

    implement the framework of fast node

commit 859186f
Merge: 74f6b61 21a3b11
Author: zjubfd <[email protected]>
Date:   Fri Jan 28 11:44:08 2022 +0800

    Merge pull request #743 from binance-chain/develop

    [R4R] Release v1.1.8

commit 6fffa8e
Author: KeefeL <[email protected]>
Date:   Thu Jan 27 16:50:59 2022 +0800

    testcases for trust protocol (#742)

commit 0b296e8
Author: Keefe-Liu <[email protected]>
Date:   Tue Jan 25 21:18:56 2022 +0800

    fix misc bugs of verify node

commit 6306002
Author: Keefe-Liu <[email protected]>
Date:   Fri Jan 21 18:17:06 2022 +0800

    generate diff layer by replaying block

commit 66dd9ea
Author: Keefe-Liu <[email protected]>
Date:   Thu Jan 20 15:22:06 2022 +0800

    testcases for getting root by diff hash

commit 885aeb9
Author: Keefe-Liu <[email protected]>
Date:   Tue Jan 11 16:17:03 2022 +0800

    implement trust protocol and verify node

commit 3f266bf
Author: RealUncle <[email protected]>
Date:   Thu Dec 2 17:40:47 2021 +0800

    implement the framework of fast node
j75689 added a commit that referenced this pull request Jun 1, 2022
@j75689
Merge pull request bnb-chain#926 from binance-chain/develop
a8bee46 
[R4R] Separate Processing and State Verification on BSC

commit 73e6147
Merge: 84bb85c 2f2b98a
Author: cryyl <[email protected]>
Date:   Fri May 6 16:48:35 2022 +0800

    Merge remote-tracking branch 'bnb-chain/develop' into separate-node

commit 84bb85c
Author: zjubfd <[email protected]>
Date:   Fri May 6 16:42:40 2022 +0800

    refine the description

commit cc1940c
Author: zjubfd <[email protected]>
Date:   Fri May 6 16:38:59 2022 +0800

    change the flag description

commit e440880
Author: dean65 <[email protected]>
Date:   Fri May 6 02:17:24 2022 +0800

    fix TestFastNode

commit 4001f37
Author: dean65 <[email protected]>
Date:   Fri May 6 02:16:57 2022 +0800

    fix sorting difflayer.storage

commit e93cced
Author: dean65 <[email protected]>
Date:   Fri May 6 01:06:14 2022 +0800

    use NewTimer instead of time.After

commit f027818
Author: cryyl <[email protected]>
Date:   Thu May 5 19:10:52 2022 +0800

    fix to resolve comments

    Signed-off-by: cryyl <[email protected]>

commit ae3bdea
Author: cryyl <[email protected]>
Date:   Thu May 5 19:10:52 2022 +0800

    fix to resolve comments

    Signed-off-by: cryyl <[email protected]>

commit 2f2b98a
Merge: 0f5a4c8 55ef216
Author: zjubfd <[email protected]>
Date:   Thu May 5 17:26:16 2022 +0800

    Merge pull request #888 from bnb-chain/develop

    [R4R] Release For BSC v1.1.10

commit 2dbc8c5
Merge: e9be0d4 0132f13
Author: realuncle <[email protected]>
Date:   Wed May 4 21:37:55 2022 +0800

    Merge pull request #14 from node-real/separate-node-test

    close verifyTask when there is no valid peer and add UT tests

commit 0132f13
Author: kyrie-yl <[email protected]>
Date:   Fri Apr 29 14:39:46 2022 +0800

    add UT tests

commit e9be0d4
Author: dean65 <[email protected]>
Date:   Fri Apr 29 10:01:16 2022 +0800

    close verifyTask when length of verifyPeers is 0

commit 8929510
Author: dean65 <[email protected]>
Date:   Thu Apr 28 17:01:05 2022 +0800

    fix tests

commit 7490499
Author: dean65 <[email protected]>
Date:   Thu Apr 28 15:22:06 2022 +0800

    setup default validator for blockchain

commit ef3ec13
Author: dean65 <[email protected]>
Date:   Thu Apr 28 14:49:38 2022 +0800

    fix lint error

commit 4771d86
Merge: 5f22105 15bc254
Author: dean65 <[email protected]>
Date:   Thu Apr 28 14:36:59 2022 +0800

    Merge remote-tracking branch 'origin/develop' into separate-node

commit 5f22105
Author: j75689 <[email protected]>
Date:   Wed Apr 27 16:20:47 2022 +0800

    add unit-test for fastnode

commit 5a254c4
Author: j75689 <[email protected]>
Date:   Wed Apr 27 10:20:27 2022 +0800

    add interval when getting ErrSnapshotStale

commit b56c19c
Author: j75689 <[email protected]>
Date:   Tue Apr 26 11:18:03 2022 +0800

    fix diffhash issue

commit 0f5a4c8
Author: Leon <[email protected]>
Date:   Mon Apr 25 10:47:02 2022 +0800

    [R4R]fix:Shift panic for zero length of heads (#870)

    * fix:Shift panic for zero length of heads

    * fix: make sure peek before shift

    * refactor and update ut

    * refactor

commit dfff219
Author: j75689 <[email protected]>
Date:   Mon Apr 25 10:25:23 2022 +0800

    fix close of closed channel issue

commit 3150755
Author: j75689 <[email protected]>
Date:   Sat Apr 23 16:29:41 2022 +0800

    fix log format

commit c840e7f
Author: j75689 <[email protected]>
Date:   Sat Apr 23 06:02:29 2022 +0800

    fix diffhash mismatch issue

commit 734d17f
Author: j75689 <[email protected]>
Date:   Sat Apr 23 06:01:23 2022 +0800

    fix gracefull shutdown issue

commit a73aad6
Author: j75689 <[email protected]>
Date:   Wed Apr 20 18:00:32 2022 +0800

    fix validateBody

commit 23913cf
Author: j75689 <[email protected]>
Date:   Wed Apr 20 17:53:52 2022 +0800

    remove unused code

commit 2e6c33b
Author: j75689 <[email protected]>
Date:   Wed Apr 20 15:52:24 2022 +0800

    don't need to send verify task when node start

commit e0cf707
Author: j75689 <[email protected]>
Date:   Wed Apr 20 15:48:47 2022 +0800

    remove unused code

commit c57fdd7
Author: j75689 <[email protected]>
Date:   Wed Apr 20 15:27:30 2022 +0800

    fix comments

commit 7ad4d02
Author: j75689 <[email protected]>
Date:   Wed Apr 20 15:13:51 2022 +0800

    Revert "change type of diffLayerChanCache to sync.Map"

    This reverts commit f8c6a4a.

commit 1e44aa6
Author: j75689 <[email protected]>
Date:   Tue Apr 19 17:54:37 2022 +0800

    fixup! rewind to last non verified block when restart fast node

commit 8c6d5a8
Author: j75689 <[email protected]>
Date:   Tue Apr 19 17:37:04 2022 +0800

    fixup! rewind to last non verified block when restart fast node

commit be53153
Author: j75689 <[email protected]>
Date:   Tue Apr 19 14:39:12 2022 +0800

    rewind to last non verified block when restart fast node

commit b3a701d
Author: j75689 <[email protected]>
Date:   Tue Apr 19 13:40:17 2022 +0800

    refactor block remote validation code

commit f8c6a4a
Author: j75689 <[email protected]>
Date:   Tue Apr 19 12:46:01 2022 +0800

    change type of diffLayerChanCache to sync.Map

commit 5675916
Author: j75689 <[email protected]>
Date:   Thu Apr 14 01:16:00 2022 +0800

    fixup! put difflayer into verifyManage cache when node restart

commit 34e8ce0
Author: j75689 <[email protected]>
Date:   Thu Apr 14 00:19:41 2022 +0800

    remove testing code

commit 161c467
Merge: b978ed3 1aeadc1
Author: j75689 <[email protected]>
Date:   Thu Apr 14 00:18:02 2022 +0800

    Merge branch 'develop' into fast-node-fix

commit b978ed3
Author: j75689 <[email protected]>
Date:   Wed Apr 13 18:40:49 2022 +0800

    put difflayer into verifyManage cache when node restart

commit 1aaab76
Author: kyrie-yl <[email protected]>
Date:   Thu Apr 7 00:21:26 2022 +0800

    verify task get difflayer cache synchronously

    Signed-off-by: kyrie-yl <[email protected]>

commit 74ecbf2
Merge: 859186f 1aeadc1
Author: zjubfd <[email protected]>
Date:   Fri Apr 8 19:06:42 2022 +0800

    Merge pull request #850 from bnb-chain/develop

    [R4R] Release v1.1.9

commit 7b070c0
Author: kyrie-yl <[email protected]>
Date:   Wed Mar 2 10:07:14 2022 +0800

    resolve comments

    Signed-off-by: kyrie-yl <[email protected]>

commit 2ed75ab
Author: kyrie-yl <[email protected]>
Date:   Tue Mar 1 13:58:20 2022 +0800

    add metrics

    Signed-off-by: kyrie-yl <[email protected]>

commit f7ef016
Author: kyrie-yl <[email protected]>
Date:   Thu Feb 24 17:13:40 2022 +0800

    fast node verification and fix conflicts

    Signed-off-by: kyrie-yl <[email protected]>

commit 1e46537
Merge: 6fffa8e 0ca4bc1
Author: zjubfd <[email protected]>
Date:   Mon Feb 14 16:59:55 2022 +0800

    Merge pull request #763 from KeefeL/dev

    [R4R]Separate Processing and State Verification on BSC: sync develop branch

commit 0ca4bc1
Merge: 6fffa8e fed2f35
Author: Keefe-Liu <[email protected]>
Date:   Mon Feb 14 12:33:53 2022 +0800

    Merge branch 'develop' into separate-node

commit fed2f35
Author: KeefeL <[email protected]>
Date:   Thu Jan 27 16:50:59 2022 +0800

    testcases for trust protocol (#742)

commit 529e66e
Author: Keefe-Liu <[email protected]>
Date:   Tue Jan 25 21:18:56 2022 +0800

    fix misc bugs of verify node

commit 0405b68
Author: Keefe-Liu <[email protected]>
Date:   Fri Jan 21 18:17:06 2022 +0800

    generate diff layer by replaying block

commit 4905aab
Author: Keefe-Liu <[email protected]>
Date:   Thu Jan 20 15:22:06 2022 +0800

    testcases for getting root by diff hash

commit c6e8652
Author: Keefe-Liu <[email protected]>
Date:   Tue Jan 11 16:17:03 2022 +0800

    implement trust protocol and verify node

commit 359906c
Author: RealUncle <[email protected]>
Date:   Thu Dec 2 17:40:47 2021 +0800

    implement the framework of fast node

commit 859186f
Merge: 74f6b61 21a3b11
Author: zjubfd <[email protected]>
Date:   Fri Jan 28 11:44:08 2022 +0800

    Merge pull request #743 from binance-chain/develop

    [R4R] Release v1.1.8

commit 6fffa8e
Author: KeefeL <[email protected]>
Date:   Thu Jan 27 16:50:59 2022 +0800

    testcases for trust protocol (#742)

commit 0b296e8
Author: Keefe-Liu <[email protected]>
Date:   Tue Jan 25 21:18:56 2022 +0800

    fix misc bugs of verify node

commit 6306002
Author: Keefe-Liu <[email protected]>
Date:   Fri Jan 21 18:17:06 2022 +0800

    generate diff layer by replaying block

commit 66dd9ea
Author: Keefe-Liu <[email protected]>
Date:   Thu Jan 20 15:22:06 2022 +0800

    testcases for getting root by diff hash

commit 885aeb9
Author: Keefe-Liu <[email protected]>
Date:   Tue Jan 11 16:17:03 2022 +0800

    implement trust protocol and verify node

commit 3f266bf
Author: RealUncle <[email protected]>
Date:   Thu Dec 2 17:40:47 2021 +0800

    implement the framework of fast node
keefel pushed a commit to keefel/bsc that referenced this pull request Jun 6, 2022
@qinglin89 @j75689
[R4R]fix:Shift panic for zero length of heads (bnb-chain#870)
2c8bace 
* fix:Shift panic for zero length of heads

* fix: make sure peek before shift

* refactor and update ut

* refactor
keefel pushed a commit to keefel/bsc that referenced this pull request Jun 6, 2022
@unclezoro
Merge pull request bnb-chain#33 from bnb-chain/issue_870
1e67a33 
[R4R]fix:Shift panic for zero length of heads (bnb-chain#870)
j75689 added a commit to j75689/bsc that referenced this pull request Jun 15, 2022
@j75689
Merge pull request bnb-chain#926 from binance-chain/develop
27bf3fe 
[R4R] Separate Processing and State Verification on BSC

commit 73e6147
Merge: 84bb85c 2f2b98a
Author: cryyl <[email protected]>
Date:   Fri May 6 16:48:35 2022 +0800

    Merge remote-tracking branch 'bnb-chain/develop' into separate-node

commit 84bb85c
Author: zjubfd <[email protected]>
Date:   Fri May 6 16:42:40 2022 +0800

    refine the description

commit cc1940c
Author: zjubfd <[email protected]>
Date:   Fri May 6 16:38:59 2022 +0800

    change the flag description

commit e440880
Author: dean65 <[email protected]>
Date:   Fri May 6 02:17:24 2022 +0800

    fix TestFastNode

commit 4001f37
Author: dean65 <[email protected]>
Date:   Fri May 6 02:16:57 2022 +0800

    fix sorting difflayer.storage

commit e93cced
Author: dean65 <[email protected]>
Date:   Fri May 6 01:06:14 2022 +0800

    use NewTimer instead of time.After

commit f027818
Author: cryyl <[email protected]>
Date:   Thu May 5 19:10:52 2022 +0800

    fix to resolve comments

    Signed-off-by: cryyl <[email protected]>

commit ae3bdea
Author: cryyl <[email protected]>
Date:   Thu May 5 19:10:52 2022 +0800

    fix to resolve comments

    Signed-off-by: cryyl <[email protected]>

commit 2f2b98a
Merge: 0f5a4c8 55ef216
Author: zjubfd <[email protected]>
Date:   Thu May 5 17:26:16 2022 +0800

    Merge pull request bnb-chain#888 from bnb-chain/develop

    [R4R] Release For BSC v1.1.10

commit 2dbc8c5
Merge: e9be0d4 0132f13
Author: realuncle <[email protected]>
Date:   Wed May 4 21:37:55 2022 +0800

    Merge pull request bnb-chain#14 from node-real/separate-node-test

    close verifyTask when there is no valid peer and add UT tests

commit 0132f13
Author: kyrie-yl <[email protected]>
Date:   Fri Apr 29 14:39:46 2022 +0800

    add UT tests

commit e9be0d4
Author: dean65 <[email protected]>
Date:   Fri Apr 29 10:01:16 2022 +0800

    close verifyTask when length of verifyPeers is 0

commit 8929510
Author: dean65 <[email protected]>
Date:   Thu Apr 28 17:01:05 2022 +0800

    fix tests

commit 7490499
Author: dean65 <[email protected]>
Date:   Thu Apr 28 15:22:06 2022 +0800

    setup default validator for blockchain

commit ef3ec13
Author: dean65 <[email protected]>
Date:   Thu Apr 28 14:49:38 2022 +0800

    fix lint error

commit 4771d86
Merge: 5f22105 15bc254
Author: dean65 <[email protected]>
Date:   Thu Apr 28 14:36:59 2022 +0800

    Merge remote-tracking branch 'origin/develop' into separate-node

commit 5f22105
Author: j75689 <[email protected]>
Date:   Wed Apr 27 16:20:47 2022 +0800

    add unit-test for fastnode

commit 5a254c4
Author: j75689 <[email protected]>
Date:   Wed Apr 27 10:20:27 2022 +0800

    add interval when getting ErrSnapshotStale

commit b56c19c
Author: j75689 <[email protected]>
Date:   Tue Apr 26 11:18:03 2022 +0800

    fix diffhash issue

commit 0f5a4c8
Author: Leon <[email protected]>
Date:   Mon Apr 25 10:47:02 2022 +0800

    [R4R]fix:Shift panic for zero length of heads (bnb-chain#870)

    * fix:Shift panic for zero length of heads

    * fix: make sure peek before shift

    * refactor and update ut

    * refactor

commit dfff219
Author: j75689 <[email protected]>
Date:   Mon Apr 25 10:25:23 2022 +0800

    fix close of closed channel issue

commit 3150755
Author: j75689 <[email protected]>
Date:   Sat Apr 23 16:29:41 2022 +0800

    fix log format

commit c840e7f
Author: j75689 <[email protected]>
Date:   Sat Apr 23 06:02:29 2022 +0800

    fix diffhash mismatch issue

commit 734d17f
Author: j75689 <[email protected]>
Date:   Sat Apr 23 06:01:23 2022 +0800

    fix gracefull shutdown issue

commit a73aad6
Author: j75689 <[email protected]>
Date:   Wed Apr 20 18:00:32 2022 +0800

    fix validateBody

commit 23913cf
Author: j75689 <[email protected]>
Date:   Wed Apr 20 17:53:52 2022 +0800

    remove unused code

commit 2e6c33b
Author: j75689 <[email protected]>
Date:   Wed Apr 20 15:52:24 2022 +0800

    don't need to send verify task when node start

commit e0cf707
Author: j75689 <[email protected]>
Date:   Wed Apr 20 15:48:47 2022 +0800

    remove unused code

commit c57fdd7
Author: j75689 <[email protected]>
Date:   Wed Apr 20 15:27:30 2022 +0800

    fix comments

commit 7ad4d02
Author: j75689 <[email protected]>
Date:   Wed Apr 20 15:13:51 2022 +0800

    Revert "change type of diffLayerChanCache to sync.Map"

    This reverts commit f8c6a4a.

commit 1e44aa6
Author: j75689 <[email protected]>
Date:   Tue Apr 19 17:54:37 2022 +0800

    fixup! rewind to last non verified block when restart fast node

commit 8c6d5a8
Author: j75689 <[email protected]>
Date:   Tue Apr 19 17:37:04 2022 +0800

    fixup! rewind to last non verified block when restart fast node

commit be53153
Author: j75689 <[email protected]>
Date:   Tue Apr 19 14:39:12 2022 +0800

    rewind to last non verified block when restart fast node

commit b3a701d
Author: j75689 <[email protected]>
Date:   Tue Apr 19 13:40:17 2022 +0800

    refactor block remote validation code

commit f8c6a4a
Author: j75689 <[email protected]>
Date:   Tue Apr 19 12:46:01 2022 +0800

    change type of diffLayerChanCache to sync.Map

commit 5675916
Author: j75689 <[email protected]>
Date:   Thu Apr 14 01:16:00 2022 +0800

    fixup! put difflayer into verifyManage cache when node restart

commit 34e8ce0
Author: j75689 <[email protected]>
Date:   Thu Apr 14 00:19:41 2022 +0800

    remove testing code

commit 161c467
Merge: b978ed3 1aeadc1
Author: j75689 <[email protected]>
Date:   Thu Apr 14 00:18:02 2022 +0800

    Merge branch 'develop' into fast-node-fix

commit b978ed3
Author: j75689 <[email protected]>
Date:   Wed Apr 13 18:40:49 2022 +0800

    put difflayer into verifyManage cache when node restart

commit 1aaab76
Author: kyrie-yl <[email protected]>
Date:   Thu Apr 7 00:21:26 2022 +0800

    verify task get difflayer cache synchronously

    Signed-off-by: kyrie-yl <[email protected]>

commit 74ecbf2
Merge: 859186f 1aeadc1
Author: zjubfd <[email protected]>
Date:   Fri Apr 8 19:06:42 2022 +0800

    Merge pull request bnb-chain#850 from bnb-chain/develop

    [R4R] Release v1.1.9

commit 7b070c0
Author: kyrie-yl <[email protected]>
Date:   Wed Mar 2 10:07:14 2022 +0800

    resolve comments

    Signed-off-by: kyrie-yl <[email protected]>

commit 2ed75ab
Author: kyrie-yl <[email protected]>
Date:   Tue Mar 1 13:58:20 2022 +0800

    add metrics

    Signed-off-by: kyrie-yl <[email protected]>

commit f7ef016
Author: kyrie-yl <[email protected]>
Date:   Thu Feb 24 17:13:40 2022 +0800

    fast node verification and fix conflicts

    Signed-off-by: kyrie-yl <[email protected]>

commit 1e46537
Merge: 6fffa8e 0ca4bc1
Author: zjubfd <[email protected]>
Date:   Mon Feb 14 16:59:55 2022 +0800

    Merge pull request bnb-chain#763 from KeefeL/dev

    [R4R]Separate Processing and State Verification on BSC: sync develop branch

commit 0ca4bc1
Merge: 6fffa8e fed2f35
Author: Keefe-Liu <[email protected]>
Date:   Mon Feb 14 12:33:53 2022 +0800

    Merge branch 'develop' into separate-node

commit fed2f35
Author: KeefeL <[email protected]>
Date:   Thu Jan 27 16:50:59 2022 +0800

    testcases for trust protocol (bnb-chain#742)

commit 529e66e
Author: Keefe-Liu <[email protected]>
Date:   Tue Jan 25 21:18:56 2022 +0800

    fix misc bugs of verify node

commit 0405b68
Author: Keefe-Liu <[email protected]>
Date:   Fri Jan 21 18:17:06 2022 +0800

    generate diff layer by replaying block

commit 4905aab
Author: Keefe-Liu <[email protected]>
Date:   Thu Jan 20 15:22:06 2022 +0800

    testcases for getting root by diff hash

commit c6e8652
Author: Keefe-Liu <[email protected]>
Date:   Tue Jan 11 16:17:03 2022 +0800

    implement trust protocol and verify node

commit 359906c
Author: RealUncle <[email protected]>
Date:   Thu Dec 2 17:40:47 2021 +0800

    implement the framework of fast node

commit 859186f
Merge: 74f6b61 21a3b11
Author: zjubfd <[email protected]>
Date:   Fri Jan 28 11:44:08 2022 +0800

    Merge pull request bnb-chain#743 from binance-chain/develop

    [R4R] Release v1.1.8

commit 6fffa8e
Author: KeefeL <[email protected]>
Date:   Thu Jan 27 16:50:59 2022 +0800

    testcases for trust protocol (bnb-chain#742)

commit 0b296e8
Author: Keefe-Liu <[email protected]>
Date:   Tue Jan 25 21:18:56 2022 +0800

    fix misc bugs of verify node

commit 6306002
Author: Keefe-Liu <[email protected]>
Date:   Fri Jan 21 18:17:06 2022 +0800

    generate diff layer by replaying block

commit 66dd9ea
Author: Keefe-Liu <[email protected]>
Date:   Thu Jan 20 15:22:06 2022 +0800

    testcases for getting root by diff hash

commit 885aeb9
Author: Keefe-Liu <[email protected]>
Date:   Tue Jan 11 16:17:03 2022 +0800

    implement trust protocol and verify node

commit 3f266bf
Author: RealUncle <[email protected]>
Date:   Thu Dec 2 17:40:47 2021 +0800

    implement the framework of fast node
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@forcodedancing forcodedancing forcodedancing approved these changes

@Mercybudda Mercybudda Mercybudda approved these changes

@unclezoro unclezoro unclezoro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@qinglin89 @unclezoro @Mercybudda @forcodedancing