-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[R4R]fix pruner block tool bug, add some check logic #817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unclezoro
approved these changes
Mar 28, 2022
unclezoro
changed the title
fix pruner block tool bug, add some check logic
[R4R]fix pruner block tool bug, add some check logic
Mar 28, 2022
LGTM |
flywukong
approved these changes
Mar 28, 2022
calmbeing
approved these changes
Mar 28, 2022
Mercybudda
approved these changes
Mar 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This was referenced Apr 8, 2022
Merged
jsvisa
added a commit
to jsvisa/bor
that referenced
this pull request
Feb 21, 2023
Signed-off-by: Delweng <[email protected]>
16 tasks
jsvisa
added a commit
to jsvisa/bor
that referenced
this pull request
Mar 1, 2023
Signed-off-by: Delweng <[email protected]>
jsvisa
added a commit
to jsvisa/bor
that referenced
this pull request
Mar 17, 2023
Signed-off-by: Delweng <[email protected]>
jsvisa
added a commit
to jsvisa/bor
that referenced
this pull request
Jun 28, 2023
Signed-off-by: Delweng <[email protected]>
manav2401
pushed a commit
to maticnetwork/bor
that referenced
this pull request
Apr 9, 2024
Signed-off-by: Delweng <[email protected]>
manav2401
added a commit
to maticnetwork/bor
that referenced
this pull request
May 9, 2024
* core/state: typo Signed-off-by: Delweng <[email protected]> * core/rawdb: backport from bnb-chain/bsc#543 Signed-off-by: Delweng <[email protected]> * eth,ethdb,node,core/state: backport from bnb-chain/bsc#543 Signed-off-by: Delweng <[email protected]> * eth,core: backport from bnb-chain/bsc#543 Signed-off-by: Delweng <[email protected]> * cmd: open db with freeze disabled Signed-off-by: Delweng <[email protected]> * cli: snapshot prune-block Signed-off-by: Delweng <[email protected]> * fix typo Signed-off-by: Delweng <[email protected]> * cli/snapshot: fix the issue of dup open db error Signed-off-by: Delweng <[email protected]> * cli/snapshot: resolve datadir and ancient before backup Signed-off-by: Delweng <[email protected]> * core: more prune-block log Signed-off-by: Delweng <[email protected]> * core: truncatetail missing f.offset Signed-off-by: Delweng <[email protected]> * core/rawdb: indextx adjust offset of pruned block Signed-off-by: Delweng <[email protected]> * core/rawdb: freezer batch should implement the offset commit, ref bnb-chain/bsc#1005 Signed-off-by: Delweng <[email protected]> * core: check of ancientdb, backport bnb-chain/bsc#817 Signed-off-by: Delweng <[email protected]> * core/state: read raw borReceipt to backup Signed-off-by: Delweng <[email protected]> * core/rawdb: bor receipt maybe in []Receipt or Receipt RLP format Signed-off-by: Delweng <[email protected]> * core/state: typo and error msg Signed-off-by: Delweng <[email protected]> * core/rawdb: offSet -> offset Signed-off-by: Delweng <[email protected]> * cli/snapshot: comment Signed-off-by: Delweng <[email protected]> * cli/snapshot: add prune-block doc Signed-off-by: Delweng <[email protected]> * docs: add prune-block document Signed-off-by: Delweng <[email protected]> * core/rawdb: print wrong bor-receipt length Signed-off-by: Delweng <[email protected]> * internal/cli: add snapshot prune block tests (referenced from bsc's PR) * improve errors * cmd, core, eth, internal: fix lint * internal/cli: refactor snapshot prune block test * fix linters in tests * internal/cli: add inspect-ancient-db command, update docs * pruner: use a generic function for simplification * internal/cli: fixes for inspect-db command * internal/cli: improve pruning tests * core/rawdb: update end block calculation logic in inspect command * core/rawdb: improve checks db initialisation * core/rawdb: remove offset check * update mocks for span, ethdb and add command in makefile * docs/cli: update docs with inspect command * go mod tidy * refactor and resolve conflicts * resolve more conflicts * refactor * explicitly read node for hash scheme * add check for hash scheme, fix tests * fix typo * update docs and add warning * raise error if pbss is enabled * revert read raw bor receipt change * consensus/bor: handle nil header case in get root hash * address comments * core/rawdb: check chain continuity by matching parent hash * core/rawdb: account for pruned ancient blocks * go mod tidy * fix tests * fix tests --------- Signed-off-by: Delweng <[email protected]> Co-authored-by: Delweng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix prune-block-tool bugs
Rationale
fix bugs: