Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R4R]add rpc method request gauge #61

Merged
merged 1 commit into from
Jan 11, 2021
Merged

[R4R]add rpc method request gauge #61

merged 1 commit into from
Jan 11, 2021

Conversation

unclezoro
Copy link
Collaborator

@unclezoro unclezoro commented Jan 10, 2021

Description

We need to do statistics of different kinds of requests, so add request count gauge for each kind of request.

Rationale

Metrics change.

Example

No

Changes

Add more monitor dashboard

Preflight checks

  • build passed (make build)
  • tests passed (make test)
  • manual transaction test passed

Already reviewed by

...

Related issues

No

@unclezoro unclezoro merged commit cfeab77 into master Jan 11, 2021
@unclezoro unclezoro deleted the requestGauge branch January 18, 2021 12:26
@unclezoro unclezoro mentioned this pull request Jan 19, 2021
3 tasks
galaio pushed a commit to galaio/bsc that referenced this pull request Jul 31, 2024
The gas price oracle calculates L1 data costs using an unsigned transaction. However, `op-geth` was calculating L1 data costs using a _signed_ transaction, which included an additional 68 unnecessary bytes (1088 gas) in the cost.

This PR removes those extra bytes as part of the Regolith hardfork.

Co-authored-by: protolambda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants