[R4R]fix potential deadlock of pub/sub module #59
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the potential deadlock of pub/sub module.
More detail in: #58
Rationale
The deadlock dependency is:
Routine A:NewPendingTransactionFilter want to lock filtersMu to consume hashes;
Routine B: eventLoop is waiting Routine A to consume hashes so that it can push new hash to channel.
Routine C: Unsubscribe is holding lock filtersMu, but it is waiting for Routine B to consume uninstall channel.
Example
add an example CLI or API response...
Changes
There is no need to fetch lock on
NewPendingTransactionFilter
routine, so just loose the logic.And fix the potential risk that
Unsubscribe
routine does not drain all thehash
,header
andlog
.Preflight checks
make build
)make test
)Already reviewed by
...
Related issues