Skip to content

core/state/snapshot: fix BAD BLOCK error when snapshot is generating …#485

Merged
unclezoro merged 1 commit intodevelopfrom
fix_bad_block_cherry_pick
Nov 1, 2021
Merged

core/state/snapshot: fix BAD BLOCK error when snapshot is generating …#485
unclezoro merged 1 commit intodevelopfrom
fix_bad_block_cherry_pick

Conversation

@Mercybudda
Copy link
Copy Markdown
Contributor

@Mercybudda Mercybudda commented Oct 27, 2021

…(#23635)

  • core/state/snapshot: fix BAD BLOCK error when snapshot is generating

  • core/state/snapshot: alternative fix for the snapshot generator

  • add comments and minor update

Co-authored-by: Martin Holst Swende martin@swende.se

Description

fix BAD BLOCK error when snapshot is generating, cherry-picked the commit of go-ethereum: ethereum/go-ethereum@312e02b

Preflight checks

  • build passed (make build)
  • tests passed (make test)
  • manual transaction test passed

Related issues

ethereum/go-ethereum#23635

@unclezoro unclezoro changed the base branch from master to develop November 1, 2021 06:56
@unclezoro
Copy link
Copy Markdown
Contributor

Can you change the code base to develop branch?

…(#23635)

* core/state/snapshot: fix BAD BLOCK error when snapshot is generating

* core/state/snapshot: alternative fix for the snapshot generator

* add comments and minor update

Co-authored-by: Martin Holst Swende <martin@swende.se>

* core/state/snapshot: fix BAD BLOCK error when snapshot is generating

* core/state/snapshot: alternative fix for the snapshot generator

* add comments and minor update

Co-authored-by: Martin Holst Swende <martin@swende.se>
@Mercybudda Mercybudda force-pushed the fix_bad_block_cherry_pick branch from 6f5fee5 to b8e0766 Compare November 1, 2021 10:46
@unclezoro unclezoro merged commit 354d0a4 into develop Nov 1, 2021
@Mercybudda Mercybudda deleted the fix_bad_block_cherry_pick branch November 2, 2021 08:38
@rothn
Copy link
Copy Markdown

rothn commented Apr 25, 2022

Looks like this fix got reverted for some reason by @greatestvillain. Does anyone know why? I'm having this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants