core/fitermaps: fix final block logic#3300
Merged
buddh0 merged 1 commit intobnb-chain:developfrom Aug 21, 2025
Merged
Conversation
allformless
commented
Aug 21, 2025
| var finalBlock uint64 | ||
| var finalBlock, currentBlock int64 | ||
| if fb := s.blockchain.CurrentFinalBlock(); fb != nil { | ||
| finalBlock = fb.Number.Uint64() |
Contributor
Author
There was a problem hiding this comment.
when sync with chapel or bsc mainnet
before luban hardfork, finalBlock will always be 0, will prevent filtermaps indexing
zzzckck
approved these changes
Aug 21, 2025
galaio
approved these changes
Aug 21, 2025
This was referenced Aug 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
core/fitermaps: fix final block logic
Rationale
tell us why we need these changes...
Example
add an example CLI or API response...
Changes
Notable changes: