Skip to content

core/types: disable EIP-7594 in BSC #3291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zzzckck merged 1 commit into from
Aug 18, 2025
Merged

core/types: disable EIP-7594 in BSC #3291

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions core/types/tx_blob.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,11 @@ type BlobTx struct {

// BlobTxSidecar contains the blobs of a blob transaction.
type BlobTxSidecar struct {
Version byte `json:"version"` // Version
// NOTE(BSC): PeerDAS support (EIP-7594) is disabled.
// Only sidecar Version = 0 (EIP-4844 legacy proofs) is supported for now.
// See upstream PR: https://github.com/ethereum/go-ethereum/pull/31791
Version byte `json:"version" rlp:"-"` // Sidecar version

Blobs []kzg4844.Blob `json:"blobs"` // Blobs needed by the blob pool
Commitments []kzg4844.Commitment `json:"commitments"` // Commitments needed by the blob pool
Proofs []kzg4844.Proof `json:"proofs"` // Proofs needed by the blob pool
Expand Down Expand Up @@ -160,7 +164,10 @@ func (btx *blobTxWithBlobsV1) tx() *BlobTx {
}

func (btx *blobTxWithBlobsV1) assign(sc *BlobTxSidecar) error {
if btx.Version != 1 {
// NOTE(BSC): Upstream geth supports both Version 0 and 1 sidecars.
// BSC only supports Version 0, as EIP-7594 (cell proofs) is not enabled yet.
disableEIP7594 := true
if disableEIP7594 || btx.Version != 1 {
return fmt.Errorf("unsupported blob tx version %d", btx.Version)
}
sc.Version = 1
Expand Down