Skip to content

api.go: add retry for snapshots stale error #3290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zzzckck merged 4 commits into from
Aug 19, 2025
Merged

api.go: add retry for snapshots stale error #3290

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8b55bd1
eth_call: add logs
zlacfzy Aug 15, 2025
6353363
eth_call: add retry if snapshots stale
zlacfzy Aug 15, 2025
e69b919
eth_call: remove logs
zlacfzy Aug 15, 2025
d14282d
eth_call: fix lint
zlacfzy Aug 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion internal/ethapi/api.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ import (
"strings"
"time"

"github.com/ethereum/go-ethereum/core/state/snapshot"

"github.com/davecgh/go-spew/spew"
"github.com/ethereum/go-ethereum/accounts"
"github.com/ethereum/go-ethereum/common"
Expand Down Expand Up @@ -1057,7 +1059,26 @@ func DoCall(ctx context.Context, b Backend, args TransactionArgs, blockNrOrHash
if state == nil || err != nil {
return nil, err
}
return doCall(ctx, b, args, state, header, overrides, blockOverrides, timeout, globalGasCap)

res, derr := doCall(ctx, b, args, state, header, overrides, blockOverrides, timeout, globalGasCap)

// Retry once if snapshot error
if derr != nil && errors.Is(derr, snapshot.ErrSnapshotStale) {
select {
case <-time.After(100 * time.Millisecond):
Copy link

Copilot AI Aug 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 100ms retry delay is a magic number that should be extracted as a named constant to improve maintainability and make it configurable if needed.

Suggested change
case <-time.After(100 * time.Millisecond):
case <-time.After(doCallRetryDelay):

Copilot uses AI. Check for mistakes.
case <-ctx.Done():
return nil, ctx.Err()
}

state, header, err = b.StateAndHeaderByNumberOrHash(ctx, blockNrOrHash)
if state == nil || err != nil {
return nil, err
}

res, derr = doCall(ctx, b, args, state, header, overrides, blockOverrides, timeout, globalGasCap)
Copy link

Copilot AI Aug 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The retry logic duplicates the state retrieval and doCall invocation. Consider extracting this into a helper function or loop to reduce code duplication.

Copilot uses AI. Check for mistakes.
}

return res, derr
}

// Call executes the given transaction on the state for the given block number.
Expand Down