Skip to content

refactor: use slices.Contains to simplify code #3245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
buddh0 merged 1 commit into from
Nov 28, 2025
Merged

refactor: use slices.Contains to simplify code #3245

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions miner/worker.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import (
"errors"
"fmt"
"math/big"
"slices"
"sync"
"sync/atomic"
"time"
Expand Down Expand Up @@ -639,15 +640,12 @@ func (w *worker) resultLoop() {
if prev, ok := w.recentMinedBlocks.Get(block.NumberU64()); ok {
doubleSign := false
prevParents := prev
for _, prevParent := range prevParents {
if prevParent == block.ParentHash() {
log.Error("Reject Double Sign!!", "block", block.NumberU64(),
"hash", block.Hash(),
"root", block.Root(),
"ParentHash", block.ParentHash())
doubleSign = true
break
}
if slices.Contains(prevParents, block.ParentHash()) {
log.Error("Reject Double Sign!!", "block", block.NumberU64(),
"hash", block.Hash(),
"root", block.Root(),
"ParentHash", block.ParentHash())
doubleSign = true
}
if doubleSign {
continue
Expand Down
6 changes: 2 additions & 4 deletions p2p/peer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,10 +203,8 @@ func (p *Peer) Caps() []Cap {
// versions is supported by both this node and the peer p.
func (p *Peer) RunningCap(protocol string, versions []uint) bool {
if proto, ok := p.running[protocol]; ok {
for _, ver := range versions {
if proto.Version == ver {
return true
}
if slices.Contains(versions, proto.Version) {
return true
}
}
return false
Expand Down