core: warm key TransactionIndexTail by writing#3196
Merged
zzzckck merged 1 commit intobnb-chain:masterfrom Jun 24, 2025
buddh0:master-with-txindex-fixed
Merged
core: warm key TransactionIndexTail by writing#3196zzzckck merged 1 commit intobnb-chain:masterfrom buddh0:master-with-txindex-fixed
zzzckck merged 1 commit intobnb-chain:masterfrom
buddh0:master-with-txindex-fixed
Conversation
zzzckck
approved these changes
Jun 24, 2025
galaio
approved these changes
Jun 24, 2025
MatusKysel
approved these changes
Jun 24, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a warm-up mechanism for the TransactionIndexTail key by performing a dummy write if the key exists in cold SST files, thereby optimizing future read performance.
- Removed the previous inline assignment for lastTail.
- Added a new code block to perform a dummy write using a batch operation if lastTail is non-nil.
Comment on lines
+137
to
+151
| lastTail := rawdb.ReadTxIndexTail(indexer.db) | ||
| if lastTail != nil { | ||
| // NOTE: The "TransactionIndexTail" key may exist only in cold SST files. | ||
| // Without a recent write, the key won't be in the memtable or block cache, | ||
| // causing every Get to trigger expensive readBlock + CRC checks. | ||
| // | ||
| // This dummy write forces the key into the memtable (and later SST), | ||
| // ensuring future reads are fast (from memory or block cache). | ||
| batch := indexer.db.NewBatch() | ||
| rawdb.WriteTxIndexTail(batch, *lastTail) | ||
|
|
||
| if err := batch.Write(); err != nil { | ||
| log.Crit("Failed to write TransactionIndexTail warm-up", "error", err) | ||
| return | ||
| } |
There was a problem hiding this comment.
[nitpick] Consider extracting the warm-up write logic into a separate function for improved readability and maintainability in case this behavior needs to be reused or extended.
Suggested change
| lastTail := rawdb.ReadTxIndexTail(indexer.db) | |
| if lastTail != nil { | |
| // NOTE: The "TransactionIndexTail" key may exist only in cold SST files. | |
| // Without a recent write, the key won't be in the memtable or block cache, | |
| // causing every Get to trigger expensive readBlock + CRC checks. | |
| // | |
| // This dummy write forces the key into the memtable (and later SST), | |
| // ensuring future reads are fast (from memory or block cache). | |
| batch := indexer.db.NewBatch() | |
| rawdb.WriteTxIndexTail(batch, *lastTail) | |
| if err := batch.Write(); err != nil { | |
| log.Crit("Failed to write TransactionIndexTail warm-up", "error", err) | |
| return | |
| } | |
| lastTail := indexer.warmUpTxIndexTail() | |
| if lastTail == nil { | |
| return |
constwz
pushed a commit
that referenced
this pull request
Jul 22, 2025
flywukong
pushed a commit
to flywukong/bsc
that referenced
this pull request
Sep 9, 2025
flywukong
pushed a commit
to flywukong/bsc
that referenced
this pull request
Sep 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
core: warm key TransactionIndexTail by writing
Rationale
tell us why we need these changes...
Example
add an example CLI or API response...
Changes
Notable changes: