eth: not begin to sync during processing broadcasted blocks or hash#3167
Merged
buddh0 merged 2 commits intobnb-chain:developfrom Jun 16, 2025
buddh0:avoid-unnecessary-sync
Merged
eth: not begin to sync during processing broadcasted blocks or hash#3167buddh0 merged 2 commits intobnb-chain:developfrom buddh0:avoid-unnecessary-sync
buddh0 merged 2 commits intobnb-chain:developfrom
buddh0:avoid-unnecessary-sync
Conversation
galaio
previously approved these changes
Jun 13, 2025
zzzckck
previously approved these changes
Jun 13, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces logic to prevent unnecessary synchronization when the node is only slightly behind, by pausing briefly and re-checking the local head before initiating a sync.
- Adds an
else ifbranch innextSyncOpto detect small total-difficulty lag (≤ common.Big2) - Sleeps for 3 seconds, then re-checks the local head to skip sync if it's caught up
zzzckck
approved these changes
Jun 14, 2025
galaio
approved these changes
Jun 16, 2025
This was referenced Jun 16, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
eth: not begin to sync during processing broadcasted blocks or hash
Rationale
A node may begin syncing after receiving a block but before it has been fully imported.
While syncing, fast finality voting is disabled. Since syncing can occasionally take up to a minute, the validator may miss one or more voting opportunities.
This behavior is unnecessary and should be avoided.
in testnet, sync too many times
Example
add an example CLI or API response...
Changes
Notable changes: