Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
A cleanup PR to remove an obsolete VM helper file that exports the instruction lookup and operation methods.
- Delete
jump_table_export.go, which containedLookupInstructionSet,Stack, andHasCostimplementations now managed elsewhere.
Comments suppressed due to low confidence (3)
core/vm/jump_table_export.go:1
- Deleting this file removes the LookupInstructionSet function; ensure all callers are updated or removed to prevent build or runtime errors.
-// Copyright 2023 The go-ethereum Authors
core/vm/jump_table_export.go:1
- If
LookupInstructionSethas been moved, update import paths in dependent packages to reference the new location.
-package vm
core/vm/jump_table_export.go:1
- With this file removed, verify that existing tests still cover instruction set lookup logic or add new tests to maintain coverage.
-// LookupInstructionSet returns the instruction set for the fork configured by
zzzckck
approved these changes
Jun 12, 2025
galaio
approved these changes
Jun 12, 2025
This was referenced Jun 16, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
add a description of your changes here...
Rationale
tell us why we need these changes...
Example
add an example CLI or API response...
Changes
Notable changes: