refactor: use maps.copy for cleaner map handling#3123
Merged
zzzckck merged 1 commit intobnb-chain:developfrom May 28, 2025
Merged
refactor: use maps.copy for cleaner map handling#3123zzzckck merged 1 commit intobnb-chain:developfrom
zzzckck merged 1 commit intobnb-chain:developfrom
Conversation
Signed-off-by: tongjicoder <tongjicoder@icloud.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors map copy operations to leverage the new maps.Copy function for cleaner and more concise map handling.
- Replaces manual map copying loops with maps.Copy in websocket, http, client options, and metrics label handling.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| rpc/websocket.go | Replaced manual copy of HTTP headers with maps.Copy. |
| rpc/http.go | Replaced manual copy of HTTP headers with maps.Copy. |
| rpc/client_opt.go | Replaced manual copy of header maps with maps.Copy. |
| metrics/label.go | Replaced manual copy of label map with maps.Copy. |
zzzckck
approved these changes
May 28, 2025
buddh0
approved these changes
May 28, 2025
This was referenced May 28, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Optimize code using a more modern writing style.
Rationale
tell us why we need these changes...
Example
add an example CLI or API response...
Changes
Notable changes: