core, ethdb: introduce database sync function (#31703)

[buddh0]

Description

core, ethdb: introduce database sync function

Rationale

new release v1.5.13 will sync from block 0 after force killed

try to fix this by cherry-picking ethereum/go-ethereum#31703

Example

add an example CLI or API response...

Changes

Notable changes:

• add each change in a bullet point here
• ...

[Copilot]

Pull Request Overview

This PR introduces new database sync functions to improve durability guarantees after a force kill by replacing the existing Sync API with distinct methods (SyncKeyValue and SyncAncient) and updates related call sites and documentation. Key changes include removing the ephemeral flag from the pebble.New function, adding dedicated sync methods for key-value and ancient data stores, and updating tests and dependent modules accordingly.

• Removed the ephemeral parameter from the pebble.New API.
• Introduced SyncKeyValue and SyncAncient functions across various database implementations.
• Updated call sites in core and test packages to use the new sync methods.

Reviewed Changes

Copilot reviewed 26 out of 26 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
ethdb/pebble/pebble.go	Updated New signature and async write comments
ethdb/memorydb/memorydb.go	Added no-op SyncKeyValue method
ethdb/leveldb/leveldb.go	Added no-op SyncKeyValue method
ethdb/database.go	Introduced KeyValueSyncer interface and removed legacy Sync methods
core/rawdb/*	Renamed Sync to SyncAncient and updated passthrough methods
core/blockchain*	Updated pebble.New calls to remove the ephemeral flag
cmd/geth/dbcmd.go	Updated BlockStore sync call to use SyncAncient

Comments suppressed due to low confidence (2)

core/rawdb/freezer.go:391

• The Sync method call on table should be updated to SyncAncient to match the new API naming, ensuring consistency and expected functionality.

if err := table.Sync(); err != nil {

ethdb/pebble/pebble.go:149

• The ephemeral parameter has been removed from the New function signature; please ensure that all related documentation and caller updates reflect this change.

func New(file string, cache int, handles int, namespace string, readonly bool) (*Database, error) {