core/systemcontracts: remove lorentz/rialto#3089
Merged
zzzckck merged 1 commit intobnb-chain:developfrom May 15, 2025
buddh0:remove-lorentz-rialto
Merged
core/systemcontracts: remove lorentz/rialto#3089zzzckck merged 1 commit intobnb-chain:developfrom buddh0:remove-lorentz-rialto
zzzckck merged 1 commit intobnb-chain:developfrom
buddh0:remove-lorentz-rialto
Conversation
zzzckck
approved these changes
May 15, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the lorentz/rialto upgrade configuration and its related contract code, as the lorentz hardfork has been passed on mainnet.
- Removed the upgrade configuration for the Rialto network in the upgrade.go file.
- Removed the Rialto contract embed and its type definition in lorentz/types.go.
- Deleted the entire lorentz/rialto/ValidatorContract file.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| core/systemcontracts/upgrade.go | Removed the Rialto upgrade configuration for the lorentz fork. |
| core/systemcontracts/lorentz/types.go | Removed the embed for the Rialto validator contract. |
| core/systemcontracts/lorentz/rialto/ValidatorContract | Deleted the obsolete Rialto contract code. |
galaio
approved these changes
May 15, 2025
This was referenced May 16, 2025
Merged
galaio
pushed a commit
to galaio/bsc
that referenced
this pull request
May 29, 2025
galaio
pushed a commit
to galaio/bsc
that referenced
this pull request
May 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
core/systemcontracts: remove lorentz/rialto
Rationale
lorentz hardfork has been passed on mainnet
so we can remove lorentz/rialto, and the flag override.lorentz
but override.lorentz is still used by many private networks, so keep it a bit more time
just remove
lorentz/rialtonow.Example
add an example CLI or API response...
Changes
Notable changes: