metrics: add more monitor metrics for EVN;#3084
Merged
zzzckck merged 3 commits intobnb-chain:developfrom May 12, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances monitoring for EVN by introducing new metrics for peer flags and block fetching performance.
- Added new EVN flag fields in the PeerInfo structure (p2p/peer.go).
- Introduced new metrics in eth/peerset.go to track proxied, whitelist, and on-chain validator peers.
- Instrumented block fetching performance metrics and improved logging for EVN peers in eth/handler.go and eth/fetcher/block_fetcher.go.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| p2p/peer.go | Added new EVN flag fields to PeerInfo for monitoring purposes. |
| eth/peerset.go | Registered new gauges for EVN peer metrics and updated feature counts. |
| eth/handler.go | Enhanced debug logging to include EVN flag status during broadcasts. |
| eth/fetcher/block_fetcher.go | Added timers and meters to track block fetching costs and outcomes. |
Comments suppressed due to low confidence (4)
p2p/peer.go:591
- [nitpick] Consider renaming 'ProxyedValidatorFlag' to 'ProxiedValidatorFlag' for clarity and consistency.
ProxyedValidatorFlag bool `json:"proxyedValidatorFlag"`
eth/peerset.go:75
- [nitpick] Consider renaming 'evnProxedPeerGuage' to 'evnProxiedPeerGauge' to correct the spelling and improve consistency.
evnProxedPeerGuage = metrics.NewRegisteredGauge("evn/peer/proxed", nil)
eth/peerset.go:76
- [nitpick] Consider renaming 'evnWhiteListPeerGuage' to 'evnWhitelistPeerGauge' to fix the spelling of 'Gauge' and standardize naming.
evnWhiteListPeerGuage = metrics.NewRegisteredGauge("evn/peer/whiteList", nil)
eth/peerset.go:77
- [nitpick] Consider renaming 'evnOnchainValidatorPeerGuage' to 'evnOnchainValidatorPeerGauge' to correct the spelling of 'Gauge'.
evnOnchainValidatorPeerGuage = metrics.NewRegisteredGauge("evn/peer/onchainValidator", nil)
MatusKysel
approved these changes
May 12, 2025
zzzckck
approved these changes
May 12, 2025
This was referenced May 16, 2025
Merged
galaio
added a commit
to galaio/bsc
that referenced
this pull request
May 29, 2025
galaio
added a commit
to galaio/bsc
that referenced
this pull request
May 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds more monitor metrics for EVN, it can be used for monitor the network improvement from EVM.
Example
You can also query the peers RPC to get the detailed EVN feature flags for a peer.
./bsc attach --exec "admin.peers" ./geth.ipcChanges
Notable changes: