Skip to content

Comments

evn: improve node ID management with better error handling#3083

Merged
zzzckck merged 1 commit intodevelopfrom
fix-node-registration-bugs
May 12, 2025
Merged

evn: improve node ID management with better error handling#3083
zzzckck merged 1 commit intodevelopfrom
fix-node-registration-bugs

Conversation

@MatusKysel
Copy link
Contributor

  • Add proper error slice handling for txPool.Add operations
  • Improve removal logic to only remove registered node IDs

@MatusKysel MatusKysel requested a review from Copilot May 12, 2025 06:48
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves node ID management by adding proper error handling for txPool.Add operations and filtering node IDs for removal and addition based on their registration status.

  • Retrieves registered node IDs and uses a lookup set for both removal and addition operations.
  • Updates the error handling logic for adding transactions to the pool.
Comments suppressed due to low confidence (1)

eth/backend.go:621

  • The diff uses 'addSet' in handleRemovals without providing its definition. Ensure that 'addSet' is properly initialized or passed as a parameter to avoid runtime errors.
if _, exists := addSet[id]; !exists {

@MatusKysel MatusKysel requested review from galaio and zzzckck May 12, 2025 07:45
@MatusKysel MatusKysel force-pushed the fix-node-registration-bugs branch from 4f663ea to 1e56ebe Compare May 12, 2025 11:14
@zzzckck zzzckck merged commit 01c3c07 into develop May 12, 2025
7 checks passed
@zzzckck zzzckck deleted the fix-node-registration-bugs branch May 14, 2025 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants