evn: improve node ID management with better error handling#3083
Merged
evn: improve node ID management with better error handling#3083
Conversation
Contributor
MatusKysel
commented
May 12, 2025
- Add proper error slice handling for txPool.Add operations
- Improve removal logic to only remove registered node IDs
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves node ID management by adding proper error handling for txPool.Add operations and filtering node IDs for removal and addition based on their registration status.
- Retrieves registered node IDs and uses a lookup set for both removal and addition operations.
- Updates the error handling logic for adding transactions to the pool.
Comments suppressed due to low confidence (1)
eth/backend.go:621
- The diff uses 'addSet' in handleRemovals without providing its definition. Ensure that 'addSet' is properly initialized or passed as a parameter to avoid runtime errors.
if _, exists := addSet[id]; !exists {
galaio
reviewed
May 12, 2025
4f663ea to
1e56ebe
Compare
galaio
approved these changes
May 12, 2025
zzzckck
approved these changes
May 12, 2025
This was referenced May 16, 2025
Merged
galaio
pushed a commit
to galaio/bsc
that referenced
this pull request
May 29, 2025
galaio
pushed a commit
to galaio/bsc
that referenced
this pull request
May 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.