performance: track large tx execution cost#3077
Merged
zzzckck merged 2 commits intobnb-chain:developfrom May 12, 2025
Merged
Conversation
zlacfzy
previously approved these changes
May 12, 2025
galaio
reviewed
May 12, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds performance tracking for large transactions by logging execution time when gas usage exceeds a 10M threshold.
- Introduces a timing measurement in ApplyTransactionWithEVM for transactions with high gas.
- Adds new imports ("time" and "log") required by the logging feature.
galaio
approved these changes
May 12, 2025
buddh0
approved these changes
May 12, 2025
This was referenced May 16, 2025
Merged
galaio
pushed a commit
to galaio/bsc
that referenced
this pull request
May 29, 2025
galaio
pushed a commit
to galaio/bsc
that referenced
this pull request
May 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Large tx could be one of the performance bottleneck, add log to track txs with GasUsed > 10M
log will be like:
Rationale
NA
Example
NA
Changes
NA