Skip to content

Comments

config: apply two default miner option#3075

Merged
alex-10072 merged 8 commits intobnb-chain:developfrom
zzzckck:miner_config_default
May 9, 2025
Merged

config: apply two default miner option#3075
alex-10072 merged 8 commits intobnb-chain:developfrom
zzzckck:miner_config_default

Conversation

@zzzckck
Copy link
Collaborator

@zzzckck zzzckck commented May 8, 2025

Description

1.Apply default value for Recommit and MaxWaitProposalInSecs

[Eth.Miner]
GasCeil = 70000000
GasPrice = 100000000
VoteEnable = true

with this configuration, Eth.Miner.Recommit & Eth.Miner.MaxWaitProposalInSecs will be 0, while their default value should be 3000000000 and 30 respectively.
This PR it to fix the default value issue of these 2 options.

2.Change the default value of the two options.
It would be more reasonable to change default value these 2 options:

  • Recommit: from 3000000000(3 seconds) to 10000000000(10 seconds)
    Notice: Recommit is a experimental value, it could be removed, but leave it for now as it has not big side effect.
  • MaxWaitProposalInSecs: from 30s to 45s
    Node restart could take ~40second
    Here if one of the restart log from a BSC full node, it took ~37 seconds
t=05-08|12:45:18.092 lvl=info msg="Got interrupt, shutting down..."
...
t=05-08|12:45:27.198 lvl=info msg="Blockchain stopped"
...
t=05-08|12:45:38.295 lvl=info msg="Set global gas cap" cap=50000000
...
t=05-08|12:45:54.706 lvl=info msg="Imported new chain segment" number=49310151 hash=0x4261de33ce8f501b98431a210f8afd19fd6cff962c5ca2c1bef8c27819522ec8 miner=0x37e9627A91DD13e453246856D58797Ad6583D762 blocks=11 txs=1450 blobs=3 mgas=170.838265 elapsed=1.013s mgasps=168.48741502505274 snapdiffs="3.59 MiB" triediffs="189.36 MiB" triedirty="126.77 MiB" trieimutabledirty="0.00 B"
t=05-08|12:45:54.706 lvl=info msg="Enable transaction acceptance when synced."

It could be partial fix for #2986

Rationale

NA

Example

NA

Changes

NA

@zzzckck zzzckck requested review from buddh0, emailtovamos and galaio May 9, 2025 02:18
buddh0
buddh0 previously approved these changes May 9, 2025
galaio
galaio previously approved these changes May 9, 2025
alex-10072
alex-10072 previously approved these changes May 9, 2025
@zzzckck zzzckck dismissed stale reviews from alex-10072 and galaio via fea699c May 9, 2025 05:52
@alex-10072 alex-10072 merged commit ff97c48 into bnb-chain:develop May 9, 2025
7 checks passed
@zzzckck zzzckck deleted the miner_config_default branch May 14, 2025 06:10
galaio pushed a commit to galaio/bsc that referenced this pull request May 29, 2025
galaio pushed a commit to galaio/bsc that referenced this pull request May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants