config: apply two default miner option#3075
Merged
alex-10072 merged 8 commits intobnb-chain:developfrom May 9, 2025
Merged
Conversation
galaio
reviewed
May 9, 2025
buddh0
approved these changes
May 9, 2025
buddh0
previously approved these changes
May 9, 2025
galaio
previously approved these changes
May 9, 2025
alex-10072
previously approved these changes
May 9, 2025
mtrackeros
approved these changes
May 9, 2025
galaio
approved these changes
May 9, 2025
alex-10072
approved these changes
May 9, 2025
This was referenced May 16, 2025
Merged
galaio
pushed a commit
to galaio/bsc
that referenced
this pull request
May 29, 2025
galaio
pushed a commit
to galaio/bsc
that referenced
this pull request
May 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
1.Apply default value for
RecommitandMaxWaitProposalInSecswith this configuration,
Eth.Miner.Recommit&Eth.Miner.MaxWaitProposalInSecswill be 0, while their default value should be 3000000000 and 30 respectively.This PR it to fix the default value issue of these 2 options.
2.Change the default value of the two options.
It would be more reasonable to change default value these 2 options:
Notice:
Recommitis a experimental value, it could be removed, but leave it for now as it has not big side effect.Node restart could take ~40second
Here if one of the restart log from a BSC full node, it took ~37 seconds
It could be partial fix for #2986
Rationale
NA
Example
NA
Changes
NA