Conversation
93abe20 to
b1bcc93
Compare
mtrackeros
approved these changes
May 9, 2025
galaio
approved these changes
May 12, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new tool ("GetLargeTxs") to the jsutils command, which allows users to retrieve large transactions within a specified block range. Key changes include updating the default value of the "turnLength" option, introducing a new "gasUsedThreshold" option, and implementing the new getLargeTxs function along with its integration in the main command handler.
Comments suppressed due to low confidence (1)
cmd/jsutils/getchainstatus.js:832
- [nitpick] The CLI option '--num' is used in multiple commands with potentially different meanings. Consider using a more descriptive name (e.g., '--blockCount') for commands that process block ranges to avoid confusion.
const size = parseInt(program.num) || 100;
Comment on lines
+871
to
+876
| for (let txIndex = 0; txIndex < blockData.transactions.length; txIndex++) { | ||
| const txData = await blockData.getTransaction(txIndex); | ||
| if (txData && txData.gasLimit >= gasUsedThreshold) { | ||
| potentialTxs.push(txData); | ||
| } | ||
| } |
There was a problem hiding this comment.
[nitpick] Consider retrieving transaction data in parallel (e.g., by collecting promises and using Promise.all) instead of awaiting each transaction sequentially to improve performance.
Suggested change
| for (let txIndex = 0; txIndex < blockData.transactions.length; txIndex++) { | |
| const txData = await blockData.getTransaction(txIndex); | |
| if (txData && txData.gasLimit >= gasUsedThreshold) { | |
| potentialTxs.push(txData); | |
| } | |
| } | |
| const transactionPromises = []; | |
| for (let txIndex = 0; txIndex < blockData.transactions.length; txIndex++) { | |
| transactionPromises.push(blockData.getTransaction(txIndex)); | |
| } | |
| const transactions = await Promise.all(transactionPromises); | |
| transactions.forEach(txData => { | |
| if (txData && txData.gasLimit >= gasUsedThreshold) { | |
| potentialTxs.push(txData); | |
| } | |
| }); |
buddh0
approved these changes
May 12, 2025
This was referenced May 16, 2025
Merged
galaio
pushed a commit
to galaio/bsc
that referenced
this pull request
May 29, 2025
galaio
pushed a commit
to galaio/bsc
that referenced
this pull request
May 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
add a description of your changes here...
Rationale
tell us why we need these changes...
Example
add an example CLI or API response...
Changes
Notable changes: