params: double FullImmutabilityThreshold for BEP-520 & BEP-524#3044
Merged
buddh0 merged 2 commits intobnb-chain:developfrom Apr 23, 2025
buddh0:change_default_value_FullImmutabilityThreshold
Merged
params: double FullImmutabilityThreshold for BEP-520 & BEP-524#3044buddh0 merged 2 commits intobnb-chain:developfrom buddh0:change_default_value_FullImmutabilityThreshold
buddh0 merged 2 commits intobnb-chain:developfrom
buddh0:change_default_value_FullImmutabilityThreshold
Conversation
Contributor
Author
|
please not squash, just keep two commits, for easier to pick |
galaio
approved these changes
Apr 23, 2025
Closed
brilliant-lx
approved these changes
Apr 23, 2025
This was referenced May 16, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
params: double FullImmutabilityThreshold for BEP-520 & BEP-524
Rationale
FullImmutabilityThresholdis now applied to block freezing, block pruning, and state history.When the block interval is reduced, the default value of
FullImmutabilityThresholdis increased accordingly to ensure consistent behavior.this PR will solve issue #3042
Note:
The
TransactionHistorythreshold remains unchanged. Its original default value is2,350,000, which is sufficiently large even with a shorter block interval.If a node requires transaction indexing over a larger number of blocks, please use the
history.transactionsflag to configure it explicitly.Example
add an example CLI or API response...
Changes
Notable changes: