Revert "miner: limit block size to eth protocol msg size (#2696)"#3039
Merged
zzzckck merged 1 commit intobnb-chain:developfrom Apr 21, 2025
buddh0:remove-block-size-limit
Merged
Revert "miner: limit block size to eth protocol msg size (#2696)"#3039zzzckck merged 1 commit intobnb-chain:developfrom buddh0:remove-block-size-limit
zzzckck merged 1 commit intobnb-chain:developfrom
buddh0:remove-block-size-limit
Conversation
This reverts commit a28262b.
blxdyx
approved these changes
Apr 21, 2025
zlacfzy
approved these changes
Apr 21, 2025
zzzckck
approved these changes
Apr 21, 2025
This was referenced May 16, 2025
Merged
galaio
pushed a commit
to galaio/bsc
that referenced
this pull request
May 29, 2025
)" (bnb-chain#3039) This reverts commit a28262b.
galaio
pushed a commit
to galaio/bsc
that referenced
this pull request
May 29, 2025
)" (bnb-chain#3039) This reverts commit a28262b.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit a28262b.
Description
Revert "miner: limit block size to eth protocol msg size (#2696)"
Rationale
Two Changes Recently:
EIP-7623 Implementation
Increased the gas cost of zero bytes from 4 to 10 gas, following EIP-7623.
Gas Limit Reduction:
The BSC gas limit is reduced from 140M to 35M.
Estimating the Maximum BSC Block Size
With the increased zero byte cost and reduced block gas limit, the maximum block size is significantly reduced, even without enforcing an explicit size cap.
21000 + (128*1024 - 110)*10 = 1,330,620 gas ≈ 1.33M35M / 1.33M ≈ 26.3 ≈ 27 transactions(27 + 6) * 128KB = 4.125MBConclusion
With this configuration, the maximum block size is now ~4.1MB, well below the previous soft cap of 10MB.
As a result, we no longer need to enforce the 10MB block size limit.
Example
add an example CLI or API response...
Changes
Notable changes: