config: apply default value for Eth.TxPool and Eth.GPO in config.toml#3023
Closed
zzzckck wants to merge 1 commit intobnb-chain:developfrom
Closed
config: apply default value for Eth.TxPool and Eth.GPO in config.toml#3023zzzckck wants to merge 1 commit intobnb-chain:developfrom
zzzckck wants to merge 1 commit intobnb-chain:developfrom
Conversation
Contributor
There was a problem hiding this comment.
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
core/txpool/legacypool/legacypool.go:172
- [nitpick] Consider replacing the hardcoded literal 1000000000 with a named constant (e.g., OneGwei) to improve clarity and maintainability.
PriceLimit: 1000000000, // by default 1 gwei
MatusKysel
approved these changes
Apr 14, 2025
zlacfzy
approved these changes
Apr 14, 2025
buddh0
approved these changes
Apr 14, 2025
galaio
approved these changes
Apr 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
similar to #3022
make it easier for node operator to setup config.toml
And also change the default value of TxPool::PriceLimit to 1Gwei, which is the latest testnet/mainnet value.
Rationale
NA
Example
NA
Changes
NA