BEP-524: Short Block Interval Phase Two: 0.75 seconds#3019
Merged
zzzckck merged 7 commits intobnb-chain:developfrom Apr 18, 2025
buddh0:bep-524-short-block-interval
Merged
BEP-524: Short Block Interval Phase Two: 0.75 seconds#3019zzzckck merged 7 commits intobnb-chain:developfrom buddh0:bep-524-short-block-interval
zzzckck merged 7 commits intobnb-chain:developfrom
buddh0:bep-524-short-block-interval
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements the BEP-524 changes for Short Block Interval Phase Two by reducing the block interval to 0.75 seconds, increasing the epoch length, and updating blob request configurations.
- Block interval changes across the consensus and miner modules
- Epoch length update and improved blob configuration with clearing of miner history
- Adjustments to ancillary utilities and configuration values to support the new timing parameters
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| params/protocol_params.go | Updated block interval and related blob request ratios |
| params/config.go | Added Maxwell blob configuration (note JSON tag issue) |
| miner/bid_simulator.go | Updated block interval reference for Maxwell fork |
| internal/ethapi/api.go | Changed epoch length assignment and related logic |
| consensus/parlia/snapshot.go | Adjusted attestation update and miner history clearing logic |
| consensus/parlia/ramanujanfork.go | Updated milliseconds unit constant for fork timing |
| consensus/parlia/parlia.go | Updated consensus block intervals and epoch evaluations |
| consensus/misc/eip4844/eip4844.go | Updated blob fee and blob count logic for Maxwell fork |
| cmd/jsutils/getchainstatus.js | Revised performance data calculation (turnLength and blockInterval) |
| cmd/geth/config.go | Adjusted blob request parameter calculations to use the new block interval |
MatusKysel
previously approved these changes
Apr 16, 2025
zlacfzy
previously approved these changes
Apr 17, 2025
galaio
approved these changes
Apr 18, 2025
zzzckck
approved these changes
Apr 18, 2025
This was referenced May 16, 2025
Merged
galaio
pushed a commit
to galaio/bsc
that referenced
this pull request
May 29, 2025
galaio
pushed a commit
to galaio/bsc
that referenced
this pull request
May 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
BEP-524: Short Block Interval Phase Two: 0.75 seconds
Rationale
tell us why we need these changes...
Example
add an example CLI or API response...
Changes