Skip to content

Comments

BEP-524: Short Block Interval Phase Two: 0.75 seconds#3019

Merged
zzzckck merged 7 commits intobnb-chain:developfrom
buddh0:bep-524-short-block-interval
Apr 18, 2025
Merged

BEP-524: Short Block Interval Phase Two: 0.75 seconds#3019
zzzckck merged 7 commits intobnb-chain:developfrom
buddh0:bep-524-short-block-interval

Conversation

@buddh0
Copy link
Contributor

@buddh0 buddh0 commented Apr 10, 2025

Description

BEP-524: Short Block Interval Phase Two: 0.75 seconds

Rationale

tell us why we need these changes...

Example

add an example CLI or API response...

Changes

  1. reduce block interval to 0.75s from 1.5s
  2. Increase the epoch length from 500 to 1000. The transition occurs at the first block where Number % 1000 == 0 after the Maxwell hard fork.
  3. clear minerHistory based on latest finalized blocks
  4. Double Blob MinBlocksForBlobRequests and introduce MinTimeDurationForBlobRequests to determine whether blob data is needed.

@buddh0 buddh0 marked this pull request as ready for review April 16, 2025 10:25
@MatusKysel MatusKysel requested a review from Copilot April 16, 2025 12:13
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements the BEP-524 changes for Short Block Interval Phase Two by reducing the block interval to 0.75 seconds, increasing the epoch length, and updating blob request configurations.

  • Block interval changes across the consensus and miner modules
  • Epoch length update and improved blob configuration with clearing of miner history
  • Adjustments to ancillary utilities and configuration values to support the new timing parameters

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
params/protocol_params.go Updated block interval and related blob request ratios
params/config.go Added Maxwell blob configuration (note JSON tag issue)
miner/bid_simulator.go Updated block interval reference for Maxwell fork
internal/ethapi/api.go Changed epoch length assignment and related logic
consensus/parlia/snapshot.go Adjusted attestation update and miner history clearing logic
consensus/parlia/ramanujanfork.go Updated milliseconds unit constant for fork timing
consensus/parlia/parlia.go Updated consensus block intervals and epoch evaluations
consensus/misc/eip4844/eip4844.go Updated blob fee and blob count logic for Maxwell fork
cmd/jsutils/getchainstatus.js Revised performance data calculation (turnLength and blockInterval)
cmd/geth/config.go Adjusted blob request parameter calculations to use the new block interval

MatusKysel
MatusKysel previously approved these changes Apr 16, 2025
zlacfzy
zlacfzy previously approved these changes Apr 17, 2025
@zzzckck zzzckck merged commit e812c99 into bnb-chain:develop Apr 18, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants