p2p/nat: remove test with default servers (#31225)#3000
Merged
zzzckck merged 1 commit intobnb-chain:developfrom Mar 28, 2025
buddh0:p2p-nat-remove-test
Merged
p2p/nat: remove test with default servers (#31225)#3000zzzckck merged 1 commit intobnb-chain:developfrom buddh0:p2p-nat-remove-test
zzzckck merged 1 commit intobnb-chain:developfrom
buddh0:p2p-nat-remove-test
Conversation
The test occasionally fails when network connectivity is bad or if it hits the wrong server. We usually don't add tests with external network dependency so I'm removing them. Fixes #31220
zlacfzy
approved these changes
Mar 28, 2025
setunapo
approved these changes
Mar 28, 2025
zzzckck
approved these changes
Mar 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
p2p/nat: remove test with default servers (#31225)
Rationale
pick from go-etherreum ethereum/go-ethereum#31225
Example
add an example CLI or API response...
Changes
Notable changes: