Skip to content

core/state: fix concurrent map read and write for stateUpdate.accounts#2990

Merged
zzzckck merged 1 commit intobnb-chain:developfrom
buddh0:fix-concurrent-map-read-write
Mar 25, 2025
Merged

core/state: fix concurrent map read and write for stateUpdate.accounts#2990
zzzckck merged 1 commit intobnb-chain:developfrom
buddh0:fix-concurrent-map-read-write

Conversation

@buddh0
Copy link
Contributor

@buddh0 buddh0 commented Mar 25, 2025

Description

core/state: fix concurrent map read and write for stateUpdate.accounts

Rationale

v1.5.7 crashed via log
Image

Example

read path is as shown in the above picture
write path:

  commitAndFlush
  	-->err := snap.Cap(ret.root, snap.CapLimit())
  		-->persisted := t.cap(diff, layers)
  			-->flattened := parent.flatten().(*diffLayer)
  				-->	for hash, data := range dl.accountData {
  					parent.accountData[hash] = data
  					}

Changes

Notable changes:

  • add each change in a bullet point here
  • ...

@buddh0 buddh0 mentioned this pull request Mar 25, 2025
@buddh0 buddh0 marked this pull request as ready for review March 25, 2025 08:47
@zzzckck zzzckck merged commit 0eb6b5a into bnb-chain:develop Mar 25, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants