config: apply default value if it is not set in config.toml#2987
Closed
zzzckck wants to merge 1 commit intobnb-chain:developfrom
Closed
config: apply default value if it is not set in config.toml#2987zzzckck wants to merge 1 commit intobnb-chain:developfrom
zzzckck wants to merge 1 commit intobnb-chain:developfrom
Conversation
zzzckck
force-pushed
the
config_default_value
branch
from
f6efa14 to
97cea4b
Compare
also update with go generate ./...
zzzckck
force-pushed
the
config_default_value
branch
from
6053def to
7563d75
Compare
Collaborator
Author
|
implemented by #3022 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
To simplify the configuration of config.toml file, node operators can just leave some options empty if they just want the default behavior.
For more background, pls refer: #2986
Rationale
R1: Why use pointer instead of zero value check
Generally, pointer value is preferable to avoid initialising unset variable. It will be nil pointer, instead of a zero-value.
Sometime we just can't tell if the zero-value decoded from the TOML file was set by user specifically or not.
For example, Alice sets the "maxPoolSize" to "0" in config.toml to disable the pool, it's better not to be taken as Alice want the default value.
Example
NA
Changes
NA