Skip to content

miner: limit max bid per builder per block to 2 from 3 #2984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
buddh0 wants to merge 1 commit into from
Closed

miner: limit max bid per builder per block to 2 from 3 #2984

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions miner/bid_simulator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,8 @@ import (

const (
// maxBidPerBuilderPerBlock is the max bid number per builder
maxBidPerBuilderPerBlock = 3
maxBidPerBuilderPerBlock = 3
LorentzMaxBidPerBuilderPerBlock = 2
)

var (
Expand Down Expand Up @@ -471,7 +472,7 @@ func (b *bidSimulator) sendBid(_ context.Context, bid *types.Bid) error {
}
}

func (b *bidSimulator) CheckPending(blockNumber uint64, builder common.Address, bidHash common.Hash) error {
func (b *bidSimulator) CheckPending(parentHash common.Hash, blockNumber uint64, builder common.Address, bidHash common.Hash) error {
b.pendingMu.Lock()
defer b.pendingMu.Unlock()

Expand All @@ -488,7 +489,12 @@ func (b *bidSimulator) CheckPending(blockNumber uint64, builder common.Address,
return errors.New("bid already exists")
}

if len(b.pending[blockNumber][builder]) >= maxBidPerBuilderPerBlock {
maxBids := maxBidPerBuilderPerBlock
parentHeader := b.chain.GetHeaderByHash(parentHash) // current block header is not available
if b.chainConfig.IsLorentz(parentHeader.Number, parentHeader.Time) {
maxBids = LorentzMaxBidPerBuilderPerBlock
}
if len(b.pending[blockNumber][builder]) >= maxBids {
return errors.New("too many bids")
}

Expand Down
2 changes: 1 addition & 1 deletion miner/miner_mev.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ func (miner *Miner) SendBid(ctx context.Context, bidArgs *types.BidArgs) (common
return common.Hash{}, types.NewInvalidBidError("builder is not registered")
}

err = miner.bidSimulator.CheckPending(bidArgs.RawBid.BlockNumber, builder, bidArgs.RawBid.Hash())
err = miner.bidSimulator.CheckPending(bidArgs.RawBid.ParentHash, bidArgs.RawBid.BlockNumber, builder, bidArgs.RawBid.Hash())
if err != nil {
return common.Hash{}, err
}
Expand Down