Skip to content

miner: add metrics for bid simulation #2974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zzzckck merged 1 commit into from
Mar 22, 2025
Merged

miner: add metrics for bid simulation #2974

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions miner/worker.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,12 @@ const (
)

var (
bidExistGauge = metrics.NewRegisteredGauge("worker/bidExist", nil)
bidWinGauge = metrics.NewRegisteredGauge("worker/bidWin", nil)
inturnBlocksGauge = metrics.NewRegisteredGauge("worker/inturnBlocks", nil)
bestBidGasUsedGauge = metrics.NewRegisteredGauge("worker/bestBidGasUsed", nil) // MGas
bestWorkGasUsedGauge = metrics.NewRegisteredGauge("worker/bestWorkGasUsed", nil) // MGas

writeBlockTimer = metrics.NewRegisteredTimer("worker/writeblock", nil)
finalizeBlockTimer = metrics.NewRegisteredTimer("worker/finalizeblock", nil)

Expand Down Expand Up @@ -1397,6 +1403,7 @@ LOOP:
// when in-turn, compare with remote work.
from := bestWork.coinbase
if w.bidFetcher != nil && bestWork.header.Difficulty.Cmp(diffInTurn) == 0 {
inturnBlocksGauge.Inc(1)
// We want to start sealing the block as late as possible here if mev is enabled, so we could give builder the chance to send their final bid.
// Time left till sealing the block.
tillSealingTime := time.Until(time.Unix(int64(bestWork.header.Time), 0)) - w.config.DelayLeftOver
Expand All @@ -1418,6 +1425,10 @@ LOOP:
bestBid := w.bidFetcher.GetBestBid(bestWork.header.ParentHash)

if bestBid != nil {
bidExistGauge.Inc(1)
bestBidGasUsedGauge.Update(int64(bestBid.bid.GasUsed) / 1_000_000)
bestWorkGasUsedGauge.Update(int64(bestWork.header.GasUsed) / 1_000_000)

log.Debug("BidSimulator: final compare", "block", bestWork.header.Number.Uint64(),
"localBlockReward", bestReward.String(),
"bidBlockReward", bestBid.packedBlockReward.String())
Expand All @@ -1434,6 +1445,8 @@ LOOP:

// blockReward(benefits delegators) and validatorReward(benefits the validator) are both optimal
if localValidatorReward.CmpBig(bestBid.packedValidatorReward) < 0 {
bidWinGauge.Inc(1)

bestWork = bestBid.env
from = bestBid.bid.Builder

Expand Down