pbs: fix an inaccurate bid result log#2959
Merged
zzzckck merged 1 commit intobnb-chain:develop_for_v1.5.8from Mar 18, 2025
Merged
pbs: fix an inaccurate bid result log#2959zzzckck merged 1 commit intobnb-chain:develop_for_v1.5.8from
zzzckck merged 1 commit intobnb-chain:develop_for_v1.5.8from
Conversation
sometimes "bestBid == nil" does not mean it is the first bid, if new block was just importing during the bid simulation, the bestBid will be clear as well. In this case, the bid is stale and useless. Keep the SetBestBid right now, as it will be cleared later anyway. Once we have more confidence, it can be removed
buddh0
approved these changes
Mar 18, 2025
zzzckck
changed the title
emailtovamos
approved these changes
Mar 18, 2025
zlacfzy
approved these changes
Mar 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR only change the misleading log, like:
Sometimes "bestBid == nil" does not mean it is the first bid, if new block was just imported during the bid simulation, the bestBid will be cleared as well. In this case, the bid is stale and useless.
Keep the SetBestBid right now, as it will be cleared later anyway. Once we have more confidence, it can be removed
Rationale
NA
Example
NA
Changes
NA